Fix missing cycloneddsidl shared library for STANDALONE_WHEELS=1#324
Open
tonichedgehog wants to merge 2 commits intoeclipse-cyclonedds:masterfrom
Open
Fix missing cycloneddsidl shared library for STANDALONE_WHEELS=1#324tonichedgehog wants to merge 2 commits intoeclipse-cyclonedds:masterfrom
tonichedgehog wants to merge 2 commits intoeclipse-cyclonedds:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I find the ability to build a standalone Python wheel of CycloneDDS very useful, especially for use in non-networked environments. I also appreciate that I can build the wheel for a version of the CycloneDDS C library that I have configured
and built for my purposes.
But, when building a standalone wheel of CycloneDDS with pip:
The
cycloneddsidlshared library is missing from the the wheel. Consequently, when the wheel is installed, it cannot be used to process idl files without having an installation of the cycloneDDS C library in the users $PATH. This MR contains 2 commits that tries to address this:The 1:st commit adds the cycloneddsidl shared library to the list of files that are to be copied into the wheel by shutils.
On Linux, blindly copying
libddsc.sointo the wheel is not sufficient, since idlc is linked tolibddsc.so.11. So the 2:nd commit adds some logic to deduce library SONAME, and copy those files into the wheel instead of the (resolved) symlinks.Presumably, the same problem applies to security_libs, but that I have not tested. I also have no idea if the changes interfere with cibuildwheel. But please let me now, perhaps that can be worked around. I think this should also close #283.