feat: enable IPv6 support for factory resolver endpoints #951

olexii4 · 2026-02-02T14:35:32Z

What does this PR do?

This change adds IPv6 support in Eclipse Che Server to enable operation in IPv6-only network environments. As Kubernetes platforms (particularly OpenShift Container Platform 4.20) migrate to IPv6, the factory resolver must handle IPv6 addresses correctly in URLs and API calls.

The implementation involved minimal, focused changes to URL validation patterns and server URL extraction, enabling full IPv6 support while maintaining complete backward compatibility with IPv4-only and dual-stack environments.

Background:

The Eclipse Che factory resolver previously failed to operate with IPv6 git server URLs due to:

URL Validation Issues: Regular expressions rejected IPv6 bracket notation (e.g., http://[::1]:8080)
Manual String Parsing: getServerUrl() methods used pattern matching that didn't account for IPv6 brackets
Regex Escaping: Host strings from IPv6 URLs were inserted into regex patterns without properly escaping the bracket characters

IPv6 Bracket Notation:

IPv6 addresses in URLs require square brackets to distinguish the address from port numbers:

✅ Correct: http://[2001:db8::1]:8080/repo.git
❌ Incorrect: http://2001:db8::1:8080/repo.git (ambiguous)

Changes:

AbstractGitlabUrlParser:
- Fixed constructor to use URI.getHost() instead of manual substring extraction
- Added IPv6 bracket escaping in getPatternMatcherByUrl()
- Updated getServerUrl() to use URI parsing for IPv6 support
AbstractGithubURLParser:
- Added IPv6 bracket escaping in getPatternMatcherByUrl()
- Updated getServerUrl() to use URI parsing for IPv6 support
AzureDevOpsURLParser:
- Added IPv6 bracket escaping in getPatternMatcherByUrl()
- Updated getServerUrl() to use URI parsing for IPv6 support

Technical Details:

Java's URI.getHost() returns IPv6 addresses WITH brackets (e.g., "[2001:db8::1]"). When constructing regex patterns, these brackets must be escaped as \[ and \] because they are special regex characters. The fix uses:

Pattern.quote() to escape the IPv6 address (without brackets)
Manual escaping of the brackets themselves

Screenshot/screencast of this PR

What issues does this PR fix or reference?

fixes: eclipse-che/che#23674

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

Release Notes

Reviewers

Reviewers, please comment how you tested the PR when approving it.

openshift-ci · 2026-02-02T14:35:53Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: olexii4

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

olexii4 · 2026-02-05T14:41:13Z

/retest

vinokurig · 2026-02-06T07:57:23Z

...-common/src/main/java/org/eclipse/che/api/factory/server/gitlab/AbstractGitlabUrlParser.java

+      //
+      // In that case, we treat "/scm" as part of the fixed endpoint prefix, not as part of the
+      // repository path.
+      final String endpointWithoutScheme =


endpointWithoutScheme => hostname ?

vinokurig · 2026-02-06T08:07:30Z

...vops/src/main/java/org/eclipse/che/api/factory/server/azure/devops/AzureDevOpsURLParser.java

+    try {
+      URI uri = URI.create(repositoryUrl);
+      if (uri.getScheme() != null && uri.getHost() != null) {
+        String serverUrl = uri.getScheme() + "://" + uri.getAuthority();


what if uri.getAuthority() is null?

vinokurig · 2026-02-06T08:09:20Z

...vops/src/main/java/org/eclipse/che/api/factory/server/azure/devops/AzureDevOpsURLParser.java

+      if (uri.getScheme() != null && uri.getHost() != null) {
+        String serverUrl = uri.getScheme() + "://" + uri.getAuthority();
+        // Remove path and query from the server URL
+        int pathIndex = repositoryUrl.indexOf(uri.getAuthority()) + uri.getAuthority().length();


please move uri.getAuthority() to a local variable.

vinokurig · 2026-02-06T08:27:44Z

@olexii4 Please update the related tests with ip v6 examples.

olexii4 · 2026-02-09T11:47:58Z

...est/java/org/eclipse/che/api/core/util/lineconsumer/ConcurrentCompositeLineConsumerTest.java

    public void verify(VerificationData verificationData) {
      List<Invocation> invocations = verificationData.getAllInvocations();
-      InvocationMatcher invocationMatcher = verificationData.getWanted();
+      MatchableInvocation invocationMatcher = verificationData.getTarget();


These changes were required for Mockito 5 compatibility. The test was using Mockito internal APIs that have breaking changes between Mockito 3.11.2 (old version) and 5.21.0 (new version):

Changes made:
Import change: org.mockito.internal.invocation.InvocationMatcher → org.mockito.invocation.MatchableInvocation

Mockito 5 moved this from internal to public API
API change: verificationData.getWanted() → verificationData.getTarget()
Method was renamed in Mockito 5's VerificationData interface

olexii4 · 2026-02-09T11:49:07Z

...infrastructure/kubernetes/docker/auth/UserSpecificDockerRegistryCredentialsProviderTest.java


    EnvironmentContext.getCurrent().setSubject(new SubjectImpl("name", "id", "token1234", false));
-    when(preferenceManager.find(anyObject(), anyObject())).thenReturn(preferences);
+    when(preferenceManager.find(anyString(), anyString())).thenReturn(preferences);


This change was required for Mockito 5 compatibility. The test was using a deprecated matcher that was removed in Mockito 5:

Change made:
Import: ArgumentMatchers.anyObject() → ArgumentMatchers.anyString()
Usage: preferenceManager.find(anyObject(), anyObject()) → preferenceManager.find(anyString(), anyString())

olexii4 · 2026-02-09T11:55:24Z

...pace/infrastructure/kubernetes/namespace/configurator/CredentialsSecretConfiguratorTest.java

-    KubernetesClient client = spy(kubernetesClient);
-    when(cheServerKubernetesClientFactory.create()).thenReturn(client);
+    kubernetesClient = kubernetesMockServer.createClient();
+    when(cheServerKubernetesClientFactory.create()).thenReturn(kubernetesClient);


These changes were required because Mockito 5 doesn't allow spy() on mock objects. This is a breaking change from Mockito 3.x:

Changes made:

Removed import static org.mockito.Mockito.spy;

Changed setup from:

kubernetesClient = spy(kubernetesMockServer.createClient()); KubernetesClient client = spy(kubernetesClient); when(cheServerKubernetesClientFactory.create()).thenReturn(client);

To:

kubernetesClient = kubernetesMockServer.createClient(); when(cheServerKubernetesClientFactory.create()).thenReturn(kubernetesClient);

olexii4 · 2026-02-09T11:59:05Z

...c/test/java/org/eclipse/che/multiuser/permission/system/JvmServicePermissionsFilterTest.java

            })
        .when(subject)
-        .checkPermission(anyObject(), anyObject(), anyObject());
+        .checkPermission(any(), any(), any());


This change was required for Mockito 5 compatibility due to the removal of the deprecated anyObject() matcher:

Change made:

Import: ArgumentMatchers.anyObject() → ArgumentMatchers.any()

Usage: checkPermission(anyObject(), anyObject(), anyObject()) → checkPermission(any(), any(), any())

- Handle edge cases where URI authority parsing fails - Add defensive null checks for URI.getAuthority() - Support IPv6 addresses in server URL extraction - Add IPv6 test coverage for GitLab, GitHub and Azure DevOps parsers Signed-off-by: Oleksii Orel <oorel@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>

Update Mockito version and adjust affected tests to use Mockito 5 compatible APIs: - Replace InvocationMatcher with MatchableInvocation - Replace getWanted() with getTarget() - Replace anyObject() with any()/anyString() - Remove spy() on mock objects Signed-off-by: Oleksii Orel <oorel@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>

Updates the license header to fix the license-maven-plugin check failure. Assisted-by: Cursor AI Signed-off-by: Oleksii Orel <oorel@redhat.com>

Updates the license headers in AzureDevOpsURLParser and AzureDevOpsURLParserTest to fix the license-maven-plugin check failure. Assisted-by: Cursor AI Signed-off-by: Oleksii Orel <oorel@redhat.com>

Optimizations: - Reduce redundant pattern matching in AzureDevOpsURLParser.parse() by reusing matcher objects instead of creating new ones - Replace ArrayList-based array concatenation with System.arraycopy in ConcurrentCompositeLineConsumerTest.appendTo() for better performance - Remove unused ArrayList import Assisted-by: Cursor AI Signed-off-by: Oleksii Orel <oorel@redhat.com>

openshift-ci · 2026-02-11T18:15:21Z

@olexii4: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/v19-bitbucket-no-pat-oauth-flow-ssh-url	`4639781`	link	true	`/test v19-bitbucket-no-pat-oauth-flow-ssh-url`
ci/prow/v19-github-no-pat-oauth-flow-ssh-url	`4639781`	link	true	`/test v19-github-no-pat-oauth-flow-ssh-url`
ci/prow/v19-gitlab-with-pat-setup-flow	`4639781`	link	true	`/test v19-gitlab-with-pat-setup-flow`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

olexii4 requested review from SDawley, ibuziuk, tolusha and vinokurig as code owners February 2, 2026 14:35

olexii4 removed the request for review from vinokurig February 2, 2026 14:35

olexii4 force-pushed the CHE-1442 branch from aca921f to 1c59dc9 Compare February 5, 2026 14:55

vinokurig reviewed Feb 6, 2026

View reviewed changes

olexii4 force-pushed the CHE-1442 branch 4 times, most recently from 31df750 to 164262d Compare February 9, 2026 11:22

olexii4 commented Feb 9, 2026

View reviewed changes

olexii4 force-pushed the CHE-1442 branch from 49e5b2c to c2e7ad1 Compare February 9, 2026 13:43

olexii4 and others added 2 commits February 11, 2026 16:18

olexii4 force-pushed the CHE-1442 branch 2 times, most recently from b894630 to 14f521d Compare February 11, 2026 15:38

olexii4 added 3 commits February 11, 2026 18:44

chore: fix license header in ConcurrentCompositeLineConsumerTest

536c51f

Updates the license header to fix the license-maven-plugin check failure. Assisted-by: Cursor AI Signed-off-by: Oleksii Orel <oorel@redhat.com>

chore: fix license headers in Azure DevOps factory resolver

18e3c2b

Updates the license headers in AzureDevOpsURLParser and AzureDevOpsURLParserTest to fix the license-maven-plugin check failure. Assisted-by: Cursor AI Signed-off-by: Oleksii Orel <oorel@redhat.com>

olexii4 force-pushed the CHE-1442 branch from 14f521d to 4639781 Compare February 11, 2026 16:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: enable IPv6 support for factory resolver endpoints #951

feat: enable IPv6 support for factory resolver endpoints #951

olexii4 commented Feb 2, 2026

Uh oh!

openshift-ci bot commented Feb 2, 2026

Uh oh!

olexii4 commented Feb 5, 2026

Uh oh!

vinokurig Feb 6, 2026

Uh oh!

vinokurig Feb 6, 2026

Uh oh!

vinokurig Feb 6, 2026

Uh oh!

vinokurig commented Feb 6, 2026

Uh oh!

olexii4 Feb 9, 2026 •

edited

Loading

Uh oh!

olexii4 Feb 9, 2026 •

edited

Loading

Uh oh!

olexii4 Feb 9, 2026

Uh oh!

olexii4 Feb 9, 2026

Uh oh!

openshift-ci bot commented Feb 11, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

feat: enable IPv6 support for factory resolver endpoints #951

Are you sure you want to change the base?

feat: enable IPv6 support for factory resolver endpoints #951

Conversation

olexii4 commented Feb 2, 2026

What does this PR do?

Background:

IPv6 Bracket Notation:

Changes:

Technical Details:

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

Release Notes

Reviewers

Uh oh!

openshift-ci bot commented Feb 2, 2026

Uh oh!

olexii4 commented Feb 5, 2026

Uh oh!

vinokurig Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

vinokurig Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

vinokurig Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

vinokurig commented Feb 6, 2026

Uh oh!

olexii4 Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

olexii4 Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

olexii4 Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

olexii4 Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

olexii4 Feb 9, 2026 •

edited

Loading

olexii4 Feb 9, 2026 •

edited

Loading

openshift-ci bot commented Feb 11, 2026 •

edited

Loading