Fix original_writer flaky test #528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emiliocuestaf
temporarily deployed
to
codecov
GitHub Actions
Inactive
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #528 +/- ##
==========================================
- Coverage 31.14% 30.24% -0.90%
==========================================
Files 16 16
Lines 594 562 -32
Branches 321 298 -23
==========================================
- Hits 185 170 -15
+ Misses 213 205 -8
+ Partials 196 187 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
emiliocuestaf
temporarily deployed
to
codecov
GitHub Actions
Inactive
emiliocuestaf
temporarily deployed
to
codecov
GitHub Actions
Inactive
juanlofer-eprosima
previously approved these changes
Nov 18, 2025
Contributor
juanlofer-eprosima
left a comment
juanlofer-eprosima
left a comment
There was a problem hiding this comment.
LGTM with greenace CI
emiliocuestaf
temporarily deployed
to
codecov
GitHub Actions
Inactive
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
Signed-off-by: Emilio Cuesta <emiliocuesta@eprosima.com>
juanlofer-eprosima
force-pushed
the
bugfix/flaky-og-writer-test
branch
from
6fe29d6 to
2eb958e
Compare
juanlofer-eprosima
temporarily deployed
to
codecov
GitHub Actions
Inactive
emiliocuestaf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test for original writer failed quite frequently because it reused some publishers subscribers for multiple tests. Now each test uses their own entitites to avoid pollution