You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
fix(schedule): reject malformed and credential-bearing EPG URLs - #522
normalizeScheduleUrl('https://'), normalizeScheduleUrl('https://example.com:bad/epg'), and normalizeScheduleUrl('https://user:pass@example.com/epg') previously returned the input instead of rejecting it. The first two are invalid URL endpoints; the third embeds credentials in a schedule URL.
Change
Validate HTTP(S) schedule URLs using the native URL parser and reject malformed URLs or URLs containing username/password. Preserve existing valid schedule URL output, including query strings. Added regression assertions in tests/station-schedule.test.mjs.
Tests
7 focused assertions passed in an isolated Node reproduction of the updated validator. Full repository npm ci && npm test and browser QA not run; CI required before review.
Risk / acceptance
Low scope, but previously accepted credential-bearing schedule URLs will now be ignored. Acceptance: valid EPG URLs remain unchanged, malformed and credential-bearing URLs return empty string, existing schedule test suite and CI pass. No deployment or release.
Base staging SHA: 58cb1f9f4db11265e5794bc8b837024c2b299543; commits: 662ce3b0008fbe938eb9f3d346fe51fce461b3ca, 5bebaa5af217b622257e9a0516838d3a9a29f929.
Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.
ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduction
normalizeScheduleUrl('https://'),normalizeScheduleUrl('https://example.com:bad/epg'), andnormalizeScheduleUrl('https://user:pass@example.com/epg')previously returned the input instead of rejecting it. The first two are invalid URL endpoints; the third embeds credentials in a schedule URL.Change
Validate HTTP(S) schedule URLs using the native URL parser and reject malformed URLs or URLs containing username/password. Preserve existing valid schedule URL output, including query strings. Added regression assertions in
tests/station-schedule.test.mjs.Tests
7 focused assertions passed in an isolated Node reproduction of the updated validator. Full repository
npm ci && npm testand browser QA not run; CI required before review.Risk / acceptance
Low scope, but previously accepted credential-bearing schedule URLs will now be ignored. Acceptance: valid EPG URLs remain unchanged, malformed and credential-bearing URLs return empty string, existing schedule test suite and CI pass. No deployment or release.
Base staging SHA:
58cb1f9f4db11265e5794bc8b837024c2b299543; commits:662ce3b0008fbe938eb9f3d346fe51fce461b3ca,5bebaa5af217b622257e9a0516838d3a9a29f929.