Skip to content

fix(schedule): reject malformed and credential-bearing EPG URLs - #522

Merged
hoangsvit merged 2 commits into
stagingfrom
fix/schedule-url-validation-20261117
Nov 17, 2026
Merged

hoangsvit merged 2 commits into
stagingfrom
fix/schedule-url-validation-20261117

Conversation

@hoangsvit

Copy link
Copy Markdown
Member

Reproduction

normalizeScheduleUrl('https://'), normalizeScheduleUrl('https://example.com:bad/epg'), and normalizeScheduleUrl('https://user:pass@example.com/epg') previously returned the input instead of rejecting it. The first two are invalid URL endpoints; the third embeds credentials in a schedule URL.

Change

Validate HTTP(S) schedule URLs using the native URL parser and reject malformed URLs or URLs containing username/password. Preserve existing valid schedule URL output, including query strings. Added regression assertions in tests/station-schedule.test.mjs.

Tests

7 focused assertions passed in an isolated Node reproduction of the updated validator. Full repository npm ci && npm test and browser QA not run; CI required before review.

Risk / acceptance

Low scope, but previously accepted credential-bearing schedule URLs will now be ignored. Acceptance: valid EPG URLs remain unchanged, malformed and credential-bearing URLs return empty string, existing schedule test suite and CI pass. No deployment or release.

Base staging SHA: 58cb1f9f4db11265e5794bc8b837024c2b299543; commits: 662ce3b0008fbe938eb9f3d346fe51fce461b3ca, 5bebaa5af217b622257e9a0516838d3a9a29f929.

@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@github-actions

github-actions Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

ePlus OnAir — PR Preview

🗃️ Preview expired. This PR is closed; the Preview link is hidden.

View build status

Preview is noindex; the full catalog is available on Staging after merge.

@hoangsvit
hoangsvit marked this pull request as ready for review November 17, 2026 08:26
@qodo-code-review

Copy link
Copy Markdown

ⓘ Qodo reviews are paused because the subscription is no longer active. Ask your workspace admin to reactivate the subscription to resume reviews. Manage billing

@hoangsvit
hoangsvit merged commit e9427c1 into staging Nov 17, 2026
10 checks passed
@hoangsvit
hoangsvit deleted the fix/schedule-url-validation-20261117 branch November 17, 2026 08:26

This branch was successfully deployed

1 active deployment
preview — 5bebaa5a Deployed Nov 17, 2026 by hoangsvit via Remove closed PR Preview #514
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant