Conversation
- Move user_key into BlobHeader and fix BlobHeader to 4k(=_data_block_size) - This feature facilitates partial read. Currently the size of (BlobHeader+user_key) varies, so we have to read header first to lookup the data start offset. With fixed header, we can compute data offset directly and save one IO to read header. Co-authored-by: yuwmao <yuwmao@ebaychina.com>
The current _get_blob implementation always reads the full blob data regardless of the offset/len parameters, which causes unnecessary I/O on HDDs when only a portion of the blob is needed. Adds an `allow_skip_verify` parameter to enable an optimized partial read path where header is skipped and only read the requested range.
* Add shard meta in create_shard API authored-by: yuwmao <yuwmao@ebaychina.com>
Corrupted user_key_size may cause invalid memory access.
Implement migration logic to detect and upgrade v1 shard superblocks during recovery. Migration is queued and written after recovery completes. Also fixes a bug where DataHeader::type was not set during shard creation.
Due to rebase aganist master Signed-off-by: Xiaoxi Chen <xiaoxchen@ebay.com>
v1_ShardInfo should have the same byte alignment as ShardInfo struct.
* add trigger gc api * support trigger gc for a specific pg
Collaborator
|
lgtm |
xiaoxichen
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainPrepare merging to maincommit: 7cf0dbc