fix(sandbox/storage): clean stale team-index entries when expiration-index orphan is swept - #3568
Closed
AdaAibaby wants to merge 2 commits into
Closed
Conversation
AdaAibaby
requested review from
ValentaTomas,
dobrac and
jakubno
as code owners
August 14, 2026 03:59
…index orphan is swept When ExpiredItems sweeps a ZSET member whose sandbox key is gone (orphaned entry), it only removed the ZSET member but left the corresponding sandboxID in the per-team SET index. These stale entries accumulate indefinitely because no other code path cleans the team index for absent sandbox keys: - TeamItems / fetchSandboxBatch silently skip nil MGET results - The healer only fills missing ZSET members, never prunes the team index - Remove() / removeSandboxScript cleans the team index atomically, but only runs on the normal Remove call path, not on external key loss Observed impact: teams with high sandbox churn and Redis key eviction (or restarts without full persistence) accumulated thousands of stale SET members, inflating team-index memory and slowing TeamItems SMEMBERS + MGET scans. Fix: when an orphaned ZSET member is found (MGET returned nil), also SREM the sandboxID from the team index. Safety: MGET just confirmed the sandbox key is absent, so we cannot unindex a live sandbox. A concurrent Add that races our SREM will SADD the sandboxID back immediately after, so the worst outcome is a brief gap in TeamItems results for one eviction cycle.
AdaAibaby
force-pushed
the
fix/sandbox-storage-stale-team-index-cleanup
branch
from
August 14, 2026 04:04
2b270e6 to
6882627
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When ExpiredItems sweeps a ZSET member whose sandbox key is gone (orphaned entry), it only removed the ZSET member but left the corresponding sandboxID in the per-team SET index. These stale entries accumulate indefinitely because no other code path cleans the team index for absent sandbox keys:
Observed impact: teams with high sandbox churn and Redis key eviction (or restarts without full persistence) accumulated thousands of stale SET members, inflating team-index memory and slowing TeamItems SMEMBERS + MGET scans.
Fix: when an orphaned ZSET member is found (MGET returned nil), also SREM the sandboxID from the team index. Safety: MGET just confirmed the sandbox key is absent, so we cannot unindex a live sandbox. A concurrent Add that races our SREM will SADD the sandboxID back immediately after, so the worst outcome is a brief gap in TeamItems results for one eviction cycle.