-
Notifications
You must be signed in to change notification settings - Fork 0
[v1.12] Expose memory mapping; Make memfile dump optional #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: firecracker-v1.12
Are you sure you want to change the base?
Conversation
|
We might also make the snapfile optional/return it as content instead. |
a3608ad to
214264f
Compare
214264f to
01f3491
Compare
|
AI helped review:
|
|
discussed in IRL, looks good to me |
An upstream patch was backported to ubuntu 24.04 6.8.0-58 kernel that makes the nx hugepages recover thread a child of the firecracker process, thus increasing process count to 7. As we're not really interested in knowing how many threads we have in this test, let's remove the assertion altogether. Signed-off-by: Riccardo Mancini <mancio@amazon.com>
…-dev/firecracker into firecracker-v1.12-direct-mem
|
bugbot run |
To gain more control over memfile handling during snapshotting, we modify the snapshot logic to optionally skip dumping the memfile.
Also, it adds info about the memory regions when requesting instance info, so we can copy the memory directly.
This is fully compatible with FC v1.12.
This PR is for viewing code changes only and won't be merged.
Note
Introduce GET /memory and /memory/mappings APIs with VMM support for resident/empty bitmaps and region mappings, and make snapshot mem_file_path optional; update swagger, seccomp, tests, and build/upload tooling.
GET /memoryandGET /memory/mappingsendpoints; wire parsing/response and document inswagger/firecracker.yaml(MemoryResponse,MemoryMappingsResponse,GuestMemoryRegionMapping).VmmActionwithGetMemory/GetMemoryMappingsandVmmDatawithMemory/MemoryMappings; pre-boot returns not-supported.GuestMemoryRegionMapping,Vm::guest_memory_mappings, andVm::get_memory_info(usesmincoreand zero-page checks) with unified page-size validation.InstanceInfowith optionalmemory_regionsfield (initialized asNone).CreateSnapshotParams.mem_file_pathoptional and only dump memory when provided; adjust API parsing, runtime handling, and tests.mincoresyscall inresources/seccomp/*-unknown-linux-musl.json..tool-versions, and minor CI script tweak; ignore.env.Written by Cursor Bugbot for commit 1dfe77c. This will update automatically on new commits. Configure here.