Disconnect from fire-and-forget background commands#211
Open
mishushakov wants to merge 3 commits into
Open
Conversation
Call .disconnect() after background commands.run calls whose output is never read, so the SDK stops holding the event stream open while the process keeps running. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
PR SummaryLow Risk Overview Reviewed by Cursor Bugbot for commit 09a29f2. Bugbot is set up for automated code reviews on this repo. Configure here. |
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
.disconnect()call after every fire-and-forget backgroundcommands.runin both the JS and Python SDKs — the cases where the command's output stream is never consumed (xdg-open,gtk-launch,Xvfb, andstartxfce4). Per the e2b SDK,disconnect()keeps the process running but stops the SDK from holding the event stream open, avoiding a leaked streaming connection for each backgrounded process. Calls whose output is read and the noVNC handle (stored and killed later) are left untouched.🤖 Generated with Claude Code