Skip to content

Allow setting sandbox start params in dashboard terminal en 1363#479

Draft
matthewlouisbrockman wants to merge 9 commits into
mainfrom
allow-setting-sandbox-start-params-in-dashboard-terminal-en-1363
Draft

Allow setting sandbox start params in dashboard terminal en 1363#479
matthewlouisbrockman wants to merge 9 commits into
mainfrom
allow-setting-sandbox-start-params-in-dashboard-terminal-en-1363

Conversation

@matthewlouisbrockman

Copy link
Copy Markdown
Contributor

No description provided.

@linear-code

linear-code Bot commented Jun 30, 2026

Copy link
Copy Markdown

EN-1363

@cla-bot cla-bot Bot added the cla-signed label Jun 30, 2026
@vercel

vercel Bot commented Jun 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
web Ready Ready Preview, Comment Jul 1, 2026 8:54am

Request Review

@cursor

cursor Bot commented Jun 30, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Changes how PTY sessions start (user, env, cwd) and adds URL-driven launch flows; mistakes could affect sandbox execution context, though confirmation gates untrusted links.

Overview
Adds configurable PTY launch options (user, cwd, env) for dashboard terminals instead of a fixed working directory.

Terminal routes and /dashboard?tab=terminal now accept user, cwd, and repeated env query params. Values are parsed into TerminalPtyOptions and passed into DashboardTerminal; links that include PTY params trigger a confirmation dialog (alongside URL commands) where users can review cwd and edit user/env before starting.

Sandbox-scoped terminal views enable allowPtySettings: a header settings control opens a PTY dialog, optional “Make default” persistence via per-user cookies, and apply triggers reconnect. Team terminal sign-in return URLs preserve the new query params.

PTY creation uses normalized options from stored defaults, URL (when not confirmation-gated), or confirmed launch settings. resolveBrowserSandboxUrl rewrites envd sandboxUrl in the browser to the 49983-{sandboxId}. host prefix for client-proxy routing.

Unit tests cover PTY parsing, cookie round-trip, URL rewriting, and the removal of hardcoded /home/user cwd.

Reviewed by Cursor Bugbot for commit 632be5b. Bugbot is set up for automated code reviews on this repo. Configure here.

Comment thread src/features/dashboard/terminal/dashboard-terminal.tsx
Comment thread src/features/dashboard/terminal/dashboard-terminal.tsx
Comment thread src/features/dashboard/terminal/dashboard-terminal.tsx
Comment thread src/features/dashboard/terminal/dashboard-terminal.tsx
Comment thread src/core/server/auth/ory/kratos-session-edge.ts Outdated
Comment thread src/features/dashboard/terminal/dashboard-terminal.tsx
Comment thread src/core/server/auth/ory/session.ts Outdated

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 4 total unresolved issues (including 3 from previous reviews).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 992bd96. Configure here.

Comment thread src/features/dashboard/terminal/dashboard-terminal.tsx
@matthewlouisbrockman matthewlouisbrockman force-pushed the allow-setting-sandbox-start-params-in-dashboard-terminal-en-1363 branch 2 times, most recently from 266409b to 632be5b Compare July 1, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant