Skip to content

fix: poll templates list while open #450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Kraci wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: poll templates list while open #450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/features/dashboard/templates/list/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ import type { TemplatesSort } from '@/core/modules/templates/models'

export const TEMPLATES_PAGE_SIZE = 50

export const TEMPLATES_REFETCH_INTERVAL_MS = 15_000

export const TEMPLATES_DEFAULT_SORT_COLUMN_ID = 'updatedAt'
export const TEMPLATES_DEFAULT_SORT_BASE = 'updated_at'
export const TEMPLATES_DEFAULT_SORT_DESC = true
Expand Down
4 changes: 4 additions & 0 deletions src/features/dashboard/templates/list/table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ import {
TEMPLATES_DEFAULT_SORT_BASE,
TEMPLATES_DEFAULT_SORT_DESC,
TEMPLATES_PAGE_SIZE,
TEMPLATES_REFETCH_INTERVAL_MS,
} from './constants'
import TemplatesHeader from './header'
import { useTemplateTableStore } from './stores/table-store'
Expand Down Expand Up @@ -92,6 +93,9 @@ export default function TemplatesTable() {
getNextPageParam: (lastPage) => lastPage.nextCursor ?? undefined,
initialCursor: undefined,
placeholderData: keepPreviousData,
refetchInterval: TEMPLATES_REFETCH_INTERVAL_MS,

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Avoid polling every cached infinite page

When a team has enough templates for table-body.tsx to auto-load multiple pages, this interval makes TanStack's infinite query refetch every cached page every 15 seconds. Because this query has no maxPages cap or reset like the builds table, a user who has scrolled through 20 pages now generates 20 /templates requests per tick just by leaving the tab focused, so the polling cost grows with scroll depth and can hammer the API; consider capping cached pages or polling only the first page/list invalidation.

Useful? React with 👍 / 👎.

@drankou drankou Jun 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kraci check this please

refetchIntervalInBackground: false,
refetchOnWindowFocus: true,
}
)
)
Expand Down
Loading