Remove Deno kernel#268
Conversation
Drops the Deno Jupyter kernel from the template along with its language tests, kernel spec, env vars, and language branches in the messaging server. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
PR SummaryMedium Risk Overview Reviewed by Cursor Bugbot for commit 25325b5. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
LGTM — straightforward removal of the Deno Jupyter kernel from the template.
Extended reasoning...
Overview
This PR removes the Deno Jupyter kernel from the sandbox template. It deletes template/deno.json, the Deno install step and DENO_INSTALL/DENO_VERSION env vars in template/template.py, the deno branches in messaging.py for env-var set/delete and change_current_directory, and the already-skipped Deno language tests from both the Python and JS SDKs.
Security risks
None. The change only removes code paths and an external install step (deno install). Removing the install actually reduces the sandbox's attack surface.
Level of scrutiny
Low. This is a mechanical removal of an unused/disabled feature — the language tests being removed were all marked @pytest.mark.skip or .skip with reason 'Deno is not supported yet', and the kernel from make_template defaults is dropped consistently. The remaining deno references in the repo (js/tests/runtimes/deno, workflow file, package.json script) are for testing the JS SDK from a Deno runtime, which is a separate concern from the in-sandbox Deno kernel being removed here.
Other factors
The changes across the three affected files are internally consistent: messaging.py no longer needs Deno branches because deno will never be passed as self.language once the kernel isn't installed, and template.py's default kernel list is updated. No bugs found by the bug hunting system.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Summary
deno.jsonkernel spec, install step, andDENO_INSTALL/DENO_VERSIONenv vars).denobranches intemplate/server/messaging.pyfor env-var set/delete andchange_current_directory.Test plan
🤖 Generated with Claude Code