Skip to content

Remove Deno kernel#268

Open
mishushakov wants to merge 2 commits into
mainfrom
mishushakov/remove-deno-kernel
Open

Remove Deno kernel#268
mishushakov wants to merge 2 commits into
mainfrom
mishushakov/remove-deno-kernel

Conversation

@mishushakov
Copy link
Copy Markdown
Member

Summary

  • Drops the Deno Jupyter kernel from the sandbox template (removed deno.json kernel spec, install step, and DENO_INSTALL/DENO_VERSION env vars).
  • Removes the (already-skipped) Deno language tests from both the Python and JS SDKs.
  • Cleans up deno branches in template/server/messaging.py for env-var set/delete and change_current_directory.

Test plan

  • CI passes (no Deno install step remains in template builds).
  • Existing language tests (python, javascript, r, bash, java) still pass.

🤖 Generated with Claude Code

Drops the Deno Jupyter kernel from the template along with its
language tests, kernel spec, env vars, and language branches in the
messaging server.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@cursor
Copy link
Copy Markdown

cursor Bot commented May 13, 2026

PR Summary

Medium Risk
Removes Deno kernel installation/config and related server-language branches, which can break any users or integrations that still invoke language: "deno" or expect the kernel to exist.

Overview
Deno kernel support is removed from the template build (no deno.json, no install step, and no Deno env vars), and the server no longer emits Deno-specific snippets for env var set/delete or change_current_directory. The (previously skipped) Deno language tests are deleted from both the JS and Python test suites, and a changeset bumps @e2b/code-interpreter-template as a minor release.

Reviewed by Cursor Bugbot for commit 25325b5. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

@claude claude Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — straightforward removal of the Deno Jupyter kernel from the template.

Extended reasoning...

Overview

This PR removes the Deno Jupyter kernel from the sandbox template. It deletes template/deno.json, the Deno install step and DENO_INSTALL/DENO_VERSION env vars in template/template.py, the deno branches in messaging.py for env-var set/delete and change_current_directory, and the already-skipped Deno language tests from both the Python and JS SDKs.

Security risks

None. The change only removes code paths and an external install step (deno install). Removing the install actually reduces the sandbox's attack surface.

Level of scrutiny

Low. This is a mechanical removal of an unused/disabled feature — the language tests being removed were all marked @pytest.mark.skip or .skip with reason 'Deno is not supported yet', and the kernel from make_template defaults is dropped consistently. The remaining deno references in the repo (js/tests/runtimes/deno, workflow file, package.json script) are for testing the JS SDK from a Deno runtime, which is a separate concern from the in-sandbox Deno kernel being removed here.

Other factors

The changes across the three affected files are internally consistent: messaging.py no longer needs Deno branches because deno will never be passed as self.language once the kernel isn't installed, and template.py's default kernel list is updated. No bugs found by the bug hunting system.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@mishushakov mishushakov enabled auto-merge (squash) May 13, 2026 18:31
@mishushakov mishushakov disabled auto-merge May 13, 2026 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants