chore: link the resolved code-interpreting page - #1758
Conversation
The code-interpreting section index has no landing page and 307s to code-interpreting/analyze-data-with-ai, dropping the query string on the way, so the UTM parameters were lost before the reader arrived. The redirect behaves the same on both the old and the new domain, so the domain change in #1754 did not fix it. Linking at the resolved path keeps the parameters. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 324ab60 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Reviewed against TASTE.md. This PR changes only two README hyperlinks and adds a changeset — no public API surface is touched, so the API-shape, parity, error, timeout, config and docstring rules (T-1..T-74) have nothing to bite on here. 0 violations.
I verified the claim in the changeset: https://docs.e2b.dev/code-interpreting?utm_source=npm&... returns 307 to https://docs.e2b.dev/code-interpreting/analyze-data-with-ai with the query string dropped, and the new path returns 200 directly — so linking the resolved path does preserve the UTM parameters. The two SDK READMEs stay in lockstep (same target, only utm_source differing per registry), which keeps the JS/Python surface consistent in spirit with T-1.
Package ArtifactsBuilt from 0050e58. Download artifacts from this workflow run. JS SDK ( npm install ./e2b-2.45.1-michael-code-interpreting-resolved-path.0.tgzCLI ( npm install ./e2b-cli-2.17.2-michael-code-interpreting-resolved-path.0.tgzPython SDK ( pip install ./e2b-2.45.1+michael.code.interpreting.resolved.path-py3-none-any.whl |
There was a problem hiding this comment.
Looks good, straightforward doc link fix.
What was reviewed: the two README link changes (JS and Python) pointing at the resolved code-interpreting/analyze-data-with-ai path while preserving each README's UTM query string, and the accompanying changeset scoping a patch bump to e2b and @ e2b/python-sdk only. No source or behavioral code is touched.
Extended reasoning...
Overview
This PR only touches three files: two README.md link updates (JS and Python SDK) and a new changeset file. The change redirects a doc link from a section index (docs.e2b.dev/code-interpreting) to the resolved article path (docs.e2b.dev/code-interpreting/analyze-data-with-ai), preserving each README's existing UTM query string. The changeset correctly declares patch bumps for e2b and @ e2b/python-sdk, matching CLAUDE.md's requirement that public-surface changes to js-sdk/python-sdk get a changeset (README changes for published packages count, and this was followed).
Security risks
None. This is a documentation link change with no code, no user input handling, no auth/crypto/permission logic involved.
Level of scrutiny
Minimal scrutiny is appropriate: a two-line link substitution repeated identically in two README files, verified directly in the diff, with no ambiguity about correctness. The changeset accurately reflects the packages affected.
Other factors
No tests are relevant to a README-only change, and none were needed per CLAUDE.md's testing guidance (tests cover affected codepaths, and there are none here). The PR description's own reproduction (curl showing the redirect drops UTM params) is a reasonable justification, though not independently re-verified over the network in this review — the fix itself (pointing directly at the final path) is self-evidently correct regardless of whether the redirect behavior claim is 100% accurate.
Follow-up to #1754. That PR moved these links to
docs.e2b.devbut left an attribution bug in place.docs.e2b.dev/code-interpretingis a section index with no landing page. It returns a 307 todocs.e2b.dev/code-interpreting/analyze-data-with-aiand drops the query string on the way, so the UTM parameters never reach the destination. The old domain behaved the same way, so this predates the migration and #1754 did not fix it.To reproduce:
The final URL has no
utm_parameters. Requestingcode-interpreting/analyze-data-with-aidirectly returns 200 with them intact.Two links. Worth a look from whoever owns this section: the resolved article is narrower than the section index the text implies, so if there is a better target for "if you need
runCode()", that is the one to use.Changeset covers
e2band@e2b/python-sdkonly, sincepackages/cliis not touched.🤖 Generated with Claude Code