feat(js-sdk): expose E2B_ENVD_CONNECTIONS env var for file REST API connection limit#1506
Open
AdaAibaby wants to merge 2 commits into
Open
feat(js-sdk): expose E2B_ENVD_CONNECTIONS env var for file REST API connection limit#1506AdaAibaby wants to merge 2 commits into
AdaAibaby wants to merge 2 commits into
Conversation
…onnection limit\n\nThe envd REST file API (files.read/files.write) had its undici connection\npool hardcoded to 10 connections with no way to override it, while the\nRPC transport (commands) allowed 200 connections configurable via\nE2B_ENVD_RPC_CONNECTIONS. Under high concurrency this 20x gap caused\nsocket write contention and crashes on the file API path.\n\n- Add getEnvdConnectionLimit() reading E2B_ENVD_CONNECTIONS (default 10)\n- Pass connectionLimit into createEnvdFetch() instead of relying on the\n hardcoded fallback\n- Add tests for the new env var (valid + malformed values)"
AdaAibaby
requested review from
ValentaTomas,
jakubno and
mishushakov
as code owners
🦋 Changeset detectedLatest commit: 477d78b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2916e3efd6
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Member
|
@matthewlouisbrockman feel free to take a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The envd REST file API (files.read/files.write) had its undici connection\npool hardcoded to 10 connections with no way to override it, while the\nRPC transport (commands) allowed 200 connections configurable via\nE2B_ENVD_RPC_CONNECTIONS. Under high concurrency this 20x gap caused\nsocket write contention and crashes on the file API path.\n\n- Add getEnvdConnectionLimit() reading E2B_ENVD_CONNECTIONS (default 10)\n- Pass connectionLimit into createEnvdFetch() instead of relying on the\n hardcoded fallback\n- Add tests for the new env var (valid + malformed values)"
/cc @mishushakov please review.