You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When Sandbox.create() is called with an mcp configuration, the sandbox is created first, then the MCP gateway is started inside it. If the gateway startup fails (non-zero exit code or exception), the error is raised but the sandbox is never cleaned up, leaving an orphaned sandbox running and consuming resources until it times out.
This issue impacts all three SDK implementations:
Python async: AsyncSandbox.create
Python sync: Sandbox.create
JS/TS: Sandbox.create
Fix
Wrap MCP gateway startup logic with try/catch:
On any gateway startup failure, run best-effort sandbox.kill() before re-raising the original error.
Catch errors from kill() separately to guarantee the original failure error is always propagated to the caller.
Code Changes
main.py: Add async cleanup with await sandbox.kill()
main.py: Add sync cleanup with sandbox.kill()
index.ts: Add cleanup logic await sandbox.kill().catch(() => {})
test_mcp_gateway_cleanup.py: 14 unit tests (Python async + sync)
mcpGatewayCleanup.test.ts: 7 unit tests (TS)
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.
Hey there, thanks for the contribution!
Could you please update the tests so they are integration tests instead of mock?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1498
Problem
When Sandbox.create() is called with an mcp configuration, the sandbox is created first, then the MCP gateway is started inside it. If the gateway startup fails (non-zero exit code or exception), the error is raised but the sandbox is never cleaned up, leaving an orphaned sandbox running and consuming resources until it times out.
This issue impacts all three SDK implementations:
Python async: AsyncSandbox.create
Python sync: Sandbox.create
JS/TS: Sandbox.create
Fix
Wrap MCP gateway startup logic with try/catch:
On any gateway startup failure, run best-effort sandbox.kill() before re-raising the original error.
Catch errors from kill() separately to guarantee the original failure error is always propagated to the caller.
Code Changes
main.py: Add async cleanup with await sandbox.kill()
main.py: Add sync cleanup with sandbox.kill()
index.ts: Add cleanup logic await sandbox.kill().catch(() => {})
test_mcp_gateway_cleanup.py: 14 unit tests (Python async + sync)
mcpGatewayCleanup.test.ts: 7 unit tests (TS)
Test Coverage
Total 21 new unit tests, all scenarios verified:
