fix: add request-level retry logic for transient errors in HTTP client transport#1497
Open
AdaAibaby wants to merge 2 commits into
Open
fix: add request-level retry logic for transient errors in HTTP client transport#1497AdaAibaby wants to merge 2 commits into
AdaAibaby wants to merge 2 commits into
Conversation
AdaAibaby
requested review from
ValentaTomas,
jakubno and
mishushakov
as code owners
|
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Add structured log messages when request-level retries are triggered,
making it easier to diagnose transient failures like h2 ConnectionTerminated.
Python SDK: uses logging.getLogger('e2b.api.retry') at WARNING level
JS SDK: uses console.warn with '[e2b]' prefix
Each log includes: HTTP method, URL, attempt number, backoff delay,
and the failure reason (status code or exception message).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1488
Note
cc @mishushakov Would appreciate your review on this change, thanks!
Implements the approach suggested by @mishushakov in #1490 — retries at the HTTP client transport level, not individual methods.
What
handle_request/handle_async_requestin transport classes to retry on transient errorswithRetry()wrapper around basefetchinhttp2.tsAll API calls (including
wait_for_build_finishpolling) automatically get retry support.Retry strategy
E2B_REQUEST_RETRIES)ConnectionTerminated,RemoteProtocolError, etc.)AbortError, 4xx responsesTests
33 new unit tests (21 Python + 12 JS), all existing tests unaffected.