Fixing efficiency symbol and adding units #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reworked and rearranged some icons and added some additional ones.
Added forwardslash to efficiency and enabled imperial units.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the regular version of the firmware, the efficiency symbol is made of two parts where the division is made with a horizontal line,
A good example of this is the
mAh/kmsymbol.Betaflight does not support those newer symbols and so I adapted to code to add a
/between themAhand thekmsymbol the same way that it is in Betaflight.The same was done for imperial units.
Important to note that if Nautical Miles are selected, the symbol still remains as
miand the user has to know that nautical miles and not regular miles are used.