Repository navigation
feat(reports): send the designer's cell and column styles in ReportColumn - #253
Merged
Merged
Conversation
…lumn ReportColumn (api v2) gets cellStyle and columnStyle, filled from ReportField and omitted from the JSON when blank, so a front end other than ZK can honor what the designer chose. The 7-argument constructor stays. SDK type updated. Refs #252 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GDh8QvbJA9soPiZXVjuYph
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #252.
ReportColumn(api v2) now carriescellStyleandcolumnStyle(CSS class names the designer set per field, applied by the ZK viewer withsetSclass), filled inReportColumns.of(field). Blank values are not sent, and the new keys are omitted from the JSON when null (@JsonInclude(NON_NULL)only on them), so the payload is unchanged for reports that do not use them. The 7-argument constructor stays.@dynamia-tools/reports-sdktype updated.Real data: 151 fields in a production-like database use
cellStyle(green lighten-5,red lighten-4, …: Materialize-style tints from the ZK theme); none usescolumnStyle.Tests:
ReportColumnStylesTest(4: mapping, blanks, JSON keys omitted/kept, old constructor) and the existingReportsApiServiceTest(25), viamvn -pl extensions/reports/sources/core -am test.tscof the SDK OK.🤖 Generated with Claude Code
https://claude.ai/code/session_01GDh8QvbJA9soPiZXVjuYph