Repository navigation
fix(vue): view renderers return the real components so DynamiaViewer draws tables, forms and CRUDs - #251
Merged
Conversation
…draws tables, forms and CRUDs
VueTableRenderer, VueFormRenderer and VueCrudRenderer returned a name-only object ({ name: 'DynamiaTable' }), which <component :is> renders as nothing. They now return Table.vue, Form.vue and Crud.vue.
Fixes #250
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GDh8QvbJA9soPiZXVjuYph
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #250.
VueTableRenderer/VueFormRenderer/VueCrudRendererreturned{ name: 'DynamiaTable' }(no template or render function), which<component :is>draws as nothing (Vue warnsComponent is missing template or render function). They now returnTable.vue,Form.vueandCrud.vue.Found replacing a hand-built table by
DynamiaViewerin an application, after #247.Tests: vue 29 (new:
DynamiaViewerwith the real table renderer draws the table rows and applies the converter, noapp.use(DynamiaVue)). Without the change that test fails.vue-tscand build OK.🤖 Generated with Claude Code
https://claude.ai/code/session_01GDh8QvbJA9soPiZXVjuYph