-
Notifications
You must be signed in to change notification settings - Fork 1
feat: generated pnl cards #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Don't we need this change for both repos? |
Yes we do, although they will use different endpoints from what i understand so was gonna get this one out to make sure there are no issues and then pr similar changes to v4-web |
src/hooks/useSharePnlImage.ts
Outdated
| return undefined; | ||
| } | ||
|
|
||
| const userImage = await imageToBase64('/hedgie-profile.png'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't we just pass https://dydx.trade/hedgie-profile.png instead of the base64 version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or maybe even have the hedgie be the default on the image generator itself?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yea we totally can, good call out - should also make this a default on the image generator for dydx cards.
src/hooks/useSharePnlImage.ts
Outdated
| enabled: Boolean(dydxAddress), | ||
| refetchOnWindowFocus: false, | ||
| refetchOnReconnect: false, | ||
| staleTime: 1000 * 60 * 2, // 2 minutes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to replace this with timeUnits (done)
Changes
Screenshots/Recordings (Optional)