Skip to content

Conversation

@dwjanus
Copy link
Collaborator

@dwjanus dwjanus commented Jan 26, 2026

Changes

  • added pnlImageApi url to env.json
  • added helper to manage image generator request
  • updated SharePnlAnalyticsDialog to use generated image

Screenshots/Recordings (Optional)

Screenshot 2026-01-26 at 2 07 09 PM

@dwjanus dwjanus requested a review from a team as a code owner January 26, 2026 19:07
@vercel
Copy link

vercel bot commented Jan 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
project-pup Building Building Preview, Comment Jan 26, 2026 7:07pm

Request Review

@dwjanus dwjanus changed the title Dwj/generated pnl cards feat: generated pnl cards Jan 27, 2026
@dwjanus dwjanus requested review from jaredvu and qardpeet January 27, 2026 16:44
@qardpeet
Copy link

Don't we need this change for both repos?

@dwjanus
Copy link
Collaborator Author

dwjanus commented Jan 27, 2026

Don't we need this change for both repos?

Yes we do, although they will use different endpoints from what i understand so was gonna get this one out to make sure there are no issues and then pr similar changes to v4-web

return undefined;
}

const userImage = await imageToBase64('/hedgie-profile.png');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't we just pass https://dydx.trade/hedgie-profile.png instead of the base64 version?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or maybe even have the hedgie be the default on the image generator itself?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yea we totally can, good call out - should also make this a default on the image generator for dydx cards.

enabled: Boolean(dydxAddress),
refetchOnWindowFocus: false,
refetchOnReconnect: false,
staleTime: 1000 * 60 * 2, // 2 minutes
Copy link
Collaborator Author

@dwjanus dwjanus Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to replace this with timeUnits (done)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants