Conversation
fix message input tests
…-react19 [patch] fix popover tests
…act19 [patch] Fix card tests in react19
…ar-react19 Update searchbar tests to react19
…eact19 Tables and DataGrid react19
…ut-react19 Fix FileInput tests at react19
…me-inputs-react19 [patch] Fix Date and Time Input tests
…react19 [patch] Fix Input components tests
…ualmenu-react19 [patch] Fix component tests in react19
…eact into jialecl/react19
| describe("Dropdown component tests", () => { | ||
| test("Renders with correct aria attributes", () => { | ||
| test("Renders with correct aria attributes", async () => { | ||
| const user = userEvent.setup({ advanceTimers: jest.advanceTimersByTime }); |
Collaborator
There was a problem hiding this comment.
{ advanceTimers: jest.advanceTimersByTime } doesn't affect how long the test takes
Collaborator
Author
There was a problem hiding this comment.
Instead of relying on userEvent timers we use jest timers, it should not affect negatively either.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
(Check off all the items before submitting)
/libdirectory./websiteas needed.Purpose
React upgraded to v19.