Skip to content

[patch] Fix Input components tests #2558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jialecl merged 4 commits into from
Sep 29, 2026
Merged

[patch] Fix Input components tests #2558

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1d1401c
Fix numberinput tests
PelayoFelgueroso Sep 29, 2026
297f9e5
fix radiogroup tests
PelayoFelgueroso Sep 29, 2026
0482d0d
fix textarea tests
PelayoFelgueroso Sep 29, 2026
7429d25
fix checkbox tests
PelayoFelgueroso Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions packages/lib/src/checkbox/Checkbox.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ describe("Checkbox component tests", () => {
fireEvent.click(checkbox);
expect(onChange).not.toHaveBeenCalled();
});
test("Read-only checkbox sends its value on submit", () => {
test("Read-only checkbox sends its value on submit", async () => {
const user = userEvent.setup();
const handlerOnSubmit = jest.fn((e: React.FormEvent<HTMLFormElement>) => {
e.preventDefault();
const formData = new FormData(e.currentTarget);
Expand All @@ -49,14 +50,15 @@ describe("Checkbox component tests", () => {
</form>
);
const submit = getByText("Submit");
userEvent.click(submit);
await user.click(submit);
expect(handlerOnSubmit).toHaveBeenCalled();
});
test("Read-only checkbox doesn't change its value with Space key", () => {
test("Read-only checkbox doesn't change its value with Space key", async () => {
const user = userEvent.setup();
const onChange = jest.fn();
const { getByRole } = render(<DxcCheckbox label="Checkbox" onChange={onChange} readOnly />);
const checkbox = getByRole("checkbox");
userEvent.tab();
await user.tab();
expect(document.activeElement === checkbox).toBeTruthy();
fireEvent.keyDown(checkbox, {
key: " ",
Expand Down Expand Up @@ -102,7 +104,8 @@ describe("Checkbox component tests", () => {
expect(checkbox.getAttribute("aria-checked")).toBe("true");
expect(submitInput?.checked).toBe(true);
});
test("Disable keyboard and mouse interactions", () => {
test("Disable keyboard and mouse interactions", async () => {
const user = userEvent.setup();
const onChange = jest.fn();
const { getByRole, getByText, container } = render(
<DxcCheckbox label="Checkbox" onChange={onChange} disabled name="test" />
Expand All @@ -115,14 +118,15 @@ describe("Checkbox component tests", () => {
expect(input.getAttribute("aria-checked")).toBe("false");
expect(input.getAttribute("aria-disabled")).toBe("true");
expect(submitInput?.checked).toBe(false);
userEvent.tab();
await user.tab();
expect(document.activeElement === input).toBeFalsy();
});
test("Keyboard interactions", () => {
test("Keyboard interactions", async () => {
const user = userEvent.setup();
const onChange = jest.fn();
const { getByRole } = render(<DxcCheckbox label="Checkbox" name="test" onChange={onChange} />);
const checkbox = getByRole("checkbox");
userEvent.tab();
await user.tab();
expect(document.activeElement === checkbox).toBeTruthy();
fireEvent.keyDown(checkbox, {
key: " ",
Expand Down
Loading
Loading