Repository navigation
Wait out schedule occurrences before recording schedule-catalog (#1102) - #1145
Merged
Merged
Conversation
The schedule-catalog fixture keeps live daily schedules. A recording that crossed one let the reference server fire it, so every response differed from the reviewed expectation and the corpus failed whatever the change (#1102). Before that fixture records, the runner now waits until one minute after any of its natural occurrences (00:00 and 06:00 UTC, 04:00 New York, 03:00 Budapest, DST-aware) that falls within the next ten minutes, and logs the wait. No fixture or expectation changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rmcdaniel
enabled auto-merge
November 11, 2026 18:55
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1102 with the issue's preferred option 1 (no fixture change).
The
schedule-catalogfixture keeps live daily schedules. A recording that crossed a natural occurrence let the reference server fire it, so every response differed from the reviewed PHP expectation and the corpus job failed for any change (observed at 09:00:00Z on 2026-11-08, merge group of #1101).Before recording any fixture with
schedule_catalog,scripts/conformance/server-parity.mjsnow callswaitOutScheduleOccurrences. If one of the fixture's occurrences falls within the next 10 minutes, it waits until one minute after it and logswaiting Ns for a schedule occurrence to pass before recording (Server #1102). The occurrences are 00:00 UTC, 06:00 UTC, 04:00 America/New_York and 03:00 Europe/Budapest, DST-aware. Both the main corpus (MySQL/PostgreSQL) and the separate SQLite recording go through this runner. The worst-case cost is about 11 minutes on a run that would otherwise have failed. Assertions and the reviewed expectation are unchanged.Checks: new
tests/Unit/ServerParityScheduleOccurrenceGuardTest.mjs(the observed 09:00Z EST crossing, EDT/CEST/CET shifts, UTC intervals, margin, far-from-occurrence = no wait), 4/4;ServerParityRunnerTest+ServerParityScheduleContractTest431/431.🤖 Generated with Claude Code