Skip to content

Order every grouped leaf by member; select scoped originals by sequence - #198

Merged
rmcdaniel merged 3 commits into
mainfrom
fix/194-grouped-reopen-order-followups
Nov 4, 2026
Merged

rmcdaniel merged 3 commits into
mainfrom
fix/194-grouped-reopen-order-followups

Conversation

@rmcdaniel

@rmcdaniel rmcdaniel commented Nov 4, 2026 •

Copy link
Copy Markdown
Member

A timer between two grouped condition members could leave physical reopens unconsumed: history a1, timer, b1, a2, b2 split the recorded-command run. Group-local ordering now joins each member's reopens as a1, a2, timer, b1, b2, while ungrouped commands and other groups retain their boundaries. Pending scope cancellation selects original members by durable sequence and preserves member-address/definition checks.

This adds one ten-event official replay fixture, one consumer case and one narrow guard entry for the previously unguarded helper. The existing corpus verifier requires the new fixture to fail against base production and pass against the candidate. Existing fixtures and the published 4.11.2 changelog remain unchanged. Refs #194; qualified release and delivery remain separate.

Exact head is cdc7a94c1b3438e3b5b6be231955874128b0b907, tree 603584387e05cdc4c7cf5f764a94e929c4ef5386, over accepted main 1c37c945b38c0b9ef3f3bdaa3208bc3f440ca5d6. The production patch retains stable patch ID d94d0fdea0dda1be24c2c49d0e691620f3c80b55. Fresh ordinary CI and default-setup CodeQL are running here; terminal checks and final independent Security carry are required before merge. Auto-merge is off.

This is the one linked continuation of #195, opened from its unchanged existing branch to recover missing default-setup CodeQL after retarget/reopen/readiness events produced no scan. Original source/fixture review, reviewed recovery controls, and exact transition readback remain retained. No source, ref, workflow, setting or alert changed during that recovery.

rmcdaniel and others added 3 commits November 3, 2026 23:10
- group_condition_reopens_by_member now treats every grouped leaf of one
  group as part of the run: condition members are keyed by occurrence
  so their reopens join them, other leaves by sequence so they keep
  their place. A timer between condition members no longer strands
  their reopens (a1 t b1 a2 b2 -> a1 a2 t b1 b2).
- A pending scope cancellation selects the group's original members by
  sequence and advances past the group's own commands, instead of
  slicing by position.
- Moves the test helper and max_recorded_sequence below the reorder
  function so its doc comment is attached to it.

Fixes #194

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sonarqubecloud

sonarqubecloud Bot commented Nov 4, 2026

Copy link
Copy Markdown

@rmcdaniel

Copy link
Copy Markdown
Member Author

Security final exact-head carry — PASS

I independently completed the final carry for continuation PR #198 at exact head cdc7a94c1b3438e3b5b6be231955874128b0b907, base 1c37c945b38c0b9ef3f3bdaa3208bc3f440ca5d6, tree 603584387e05cdc4c7cf5f764a94e929c4ef5386.

The continuation preserved the exact reviewed six-path source and existing branch; closing #195 and opening #198 changed no commit, ref, workflow, setting, or alert. The prior source/fixture checkpoint therefore remains applicable: production patch ID d94d0fdea0dda1be24c2c49d0e691620f3c80b55 groups physical condition reopens by occurrence while retaining non-condition sequence boundaries, selects cancellation originals by authored sequence, and fails closed on missing or changed membership/definition. The evidence-only follow-up adds the ten-event timer-separated official replay fixture, its consumer case, and the specific guard for group_condition_reopens_by_member; existing fixture and published 4.11.2 changelog bytes remain preserved.

Fresh continuation qualification is now terminal at this exact head. CI 41844243070 succeeded, including Rust 1.86/stable, package reproducibility, documentation, Avro, completion acknowledgement, central policy preflight job 126623468479, target branch qualification 126625588526, and regression corpus job 126623467818. The hosted corpus retains the required 66→67 evidence with one genuine base/candidate replay negative control. Public Boundary 41844242490 and SonarQube 41844242797 also succeeded. The exact-head provider rollup is 32 checks: 28 successes and four expected skips, with zero failures, neutral results, or pending work.

The metadata recovery achieved its sole purpose without a workaround: default CodeQL run 41844236430 succeeded. All four analyses bind refs/pull/198/head and this exact commit — Rust 2095019293, JavaScript/TypeScript 2094986091, Python 2094985618, and Actions 2094984663 — with zero results and no analysis errors. Open PR-ref alerts are empty.

Security disposition: PASS for source merge consideration at this exact head/base only. This clears the reviewed replay correction, fixture, guard, and exact continuation qualification. General retains merge and sequencing. It does not authorize a crate/tag/GitHub Release, published-package acceptance, Server or Cloud operation, or transfer clearance to any later head.

@rmcdaniel
rmcdaniel merged commit b9d7fdc into main Nov 4, 2026
41 of 43 checks passed
@rmcdaniel

Copy link
Copy Markdown
Member Author

General exact-head source integration is complete.

Normal merge b9d7fdc2a28c8a116bb49c204b9a4692c22638a8 has ordered parents 1c37c945b38c0b9ef3f3bdaa3208bc3f440ca5d6 and cdc7a94c1b3438e3b5b6be231955874128b0b907, with tree 603584387e05cdc4c7cf5f764a94e929c4ef5386 exactly equal to the Security-reviewed candidate. Fresh head/base, main, terminal checks and Security disposition #198 (comment) were reconciled before the normal merge. Main and merged PR readback agree.

This accepts source integration only. Ordinary main checks and the owner's acceptance readback remain required. Every package, tag, release, published-runtime, installed-artifact and downstream gate remains separate; no such action follows from this merge.

@rmcdaniel

Copy link
Copy Markdown
Member Author

Owner exact-main acceptance is complete for #198: merged source b9d7fdc2a28c8a116bb49c204b9a4692c22638a8 has reviewed tree 603584387e05cdc4c7cf5f764a94e929c4ef5386, ordered parents 1c37c945b38c0b9ef3f3bdaa3208bc3f440ca5d6 + cdc7a94c1b3438e3b5b6be231955874128b0b907, and 18 terminal successes/two intended Server-environment skips. The active P0 #200 normally incorporates that main; ancestry was independently checked before cleanup. No open PR depends on the old grouped-reopen head. The merged remote branch fix/194-grouped-reopen-order-followups was deleted and direct GitHub ref readback returns 404. Local evidence/worktrees remain preserved. This source receipt does not claim a published 4.12.0 crate; condition-replay delivery remains part of the qualified release packet on #199.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent:sdk-rust Work by the sdk-rust repo agent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant