[rmcdaniel]

Fixes #184. Test-only; no product code changes.

Problem

On macOS and the BSDs, an accepted socket inherits the listening socket's O_NONBLOCK; on Linux it does not. Three in-process fixture servers set their listener non-blocking and then read each accepted stream. On a Mac read() returned WouldBlock immediately, the fixture parsed an empty request, and it answered 404 {"message":"not found"}. Hosted CI (Linux) was green, but the suite failed for anyone running it on macOS. These were the "flaky" local failures on #182 and #183.

Change

Right after accept(), each fixture sets the stream to blocking and gives it a write timeout:

• tests/replay_regression_corpus.rs, the replay fixture server;
• tests/sticky_server.rs, the sticky proxy (it already had a read timeout);
• src/lib.rs, the test-module MockWorkerServer (it already had a 200 ms read timeout).

The write timeout matters. With blocking writes and no timeout, runtime_upload_rejects_invalid_discovery_before_upload hung forever: on its oversized-manifest case the client stops reading, the server blocks writing, and the server's shutdown join waits on it. Non-blocking writes used to fail fast there. The timeout keeps that behavior bounded.

tests/worker_registration.rs and the runtime_uploads credential-sink listener never read an accepted stream, so they're unchanged.

Evidence (lab2, macOS arm64, Rust 1.86.0, -j2)

• Before, on main bee4465: storage-paused-cold-completion fails 3/3 with the 404 above. A full run had 7–17 failures depending on load.
• After: the full cargo test --locked --no-fail-fast --all-targets --all-features run passes 770 tests with 0 failures across 45 targets.
• Without the write timeout, runtime_upload_rejects_invalid_discovery_before_upload runs over 60 s and has to be killed. With it, tests::runtime_uploads passes 16/16 in about 4 s.

🤖 Generated with Claude Code

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[rmcdaniel]

General interim review (Security unavailable; General didn't write this PR): exact head aa1ca95b8d62c99271a44e15b3eb2caaac6316e7 is CLEARED.

The change is test-only, 3 files and 11 added lines:

• src/lib.rs: the hunk sits inside mod tests (the MockWorkerServer).
• tests/replay_regression_corpus.rs and tests/sticky_server.rs: the fixture servers.

What it does: accepted fixture sockets are set to blocking, because on macOS/BSD they inherit the listener's O_NONBLOCK. They also get a write timeout, so a client that stops reading can't hang the shutdown join.

Results: this explains the macOS-only flakes and 404s. The author reports the local full suite at 770/0, while main fails storage-paused-cold-completion 3/3 on lab2.

CI: 17 pass, 2 input-selected skips. Merge state CLEAN.

Merge only this SHA.

[rmcdaniel]

Merge readback: 4140b3d, parents bee4465 + cleared aa1ca95. Merge tree 47c419fd equals the head tree. Head branch deleted; #184 closed.