Repository navigation
Conversation
…ease tooling Follow-ups from the General interim review of #178 at 675236e: - the release-source allowlist test also fails a step without working-directory that enters release-source with cd or pushd; - install-release-tooling.sh unsets PYTHONPATH, because pip runs the target venv interpreter as a child that -I does not protect. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups from the General interim review of #178 (cleared at 675236e). This is stacked on #178's branch so the diff shows only these two changes. It retargets to
mainonce #178 merges, and won't merge before #178.Changes
test_tagged_tree_working_directory_runs_only_maintained_entrypointsalready pins everyworking-directory: release-sourcestep to an allowlisted command. It now also fails any step without a working directory whoserun:enters the tree withcdorpushd(ENTERS_TAGGED_TREE), for examplecd release-source && …,pushd ./release-sourceorcd "$GITHUB_WORKSPACE/release-source".git -C release-source …, which the workflow uses to read the tag commit, stays allowed. A separate test pins the detector's positive and negative cases.unset PYTHONPATHininstall-release-tooling.sh.-Iprotects the interpreters the script starts, butpip --python <venv>/bin/pythonruns the target interpreter as a child, and that child would still readPYTHONPATH. The installer trust test now sets a hostilePYTHONPATH, and its stub interpreter refuses if the variable reaches it.Evidence
Targeted tests in a bounded
rust:1.86.0-bookwormcontainer (Python 3.11): the 5 affected tests pass.Counterfactuals on a scratch clone:
cd release-source && head_commit=…fails the allowlist test with the matched command.unset PYTHONPATHfails the installer test with "PYTHONPATH reached the release tooling interpreter".The full
test-publish-rust-sdk.pyneeds the hash-locked release tooling (markdown_itand others) that CI installs, so hosted CI is the authority for the complete suite.🤖 Generated with Claude Code