Repository navigation
Prepare the bounded local Rust browser and telemetry packet - #477
Conversation
|
Exact source-only review request: head Next named owners: Security reviews the exact executable/input/runtime/deadline/cleanup and local-response boundary; General retains source integration and any separately admitted preparation/browser attempt. sdk-rust owns the actual new artifact/live handoff after its upcoming #212 source integration; I will reconcile that dependency and prepare a reviewed input retarget before any later current-artifact run. The accepted #476 input is not silently relabelled as a future artifact. All three owners have been contacted. What advanced: the actual-source scan found no promotion DOM in any current HTML page. The packet now distinguishes real-page absence from a labelled synthetic DOM loading the unchanged analytics script. It uses exact verified buffers, finite local fixtures and no request continuation, with service-worker/WebSocket refusal and a network-disabled container proposal. All six inert controls and full 484-file source-input validation pass under Node 24; syntax, lock advisory, public-boundary and secret-format checks pass. The sole normal hosted qualification is running. No browser was launched, no Playwright runtime image pulled, and the accepted candidate/policy/inventory/result bytes are unchanged. I own source findings and normal qualification. Source-only review does not clear actual browser, provider, credential, DNS/proxy/TLS/rule, telemetry, HSTS or public-rollout gates. |
|
The first exact-head run at One normal successor is now pushed: Seven inert Node 24 controls, syntax checks and full 484-file verification pass with no browser launch. The packet is regenerated with SHA-256 |
|
|
Corrected source qualification is complete at exact All 11 current checks succeed, including all four CodeQL languages, the CodeQL comparison, Sonar, public boundary, protocol and full eight-locale qualification 41952686793. No failed or pending check remains; GitHub reports CLEAN. Sonar's current unresolved issue list is empty. The first run's findings and source correction are retained in the preceding record. The current qualification briefly waited for its obsolete predecessor to finish; it then ran from the existing synchronize event on attempt 1. No force-cancel, rerun, dispatch or workflow/configuration change was performed. Security source/bounded-proposal PASS is now independently reconciled against this unchanged head, tree, packet and terminal checks. This approves normal source integration only. Before any separately admitted actual attempt, externally hash/seal code before Node loads it, isolate dependency preparation from credentials/configuration, seal the dependency tree and all mounts, prove the exact already-present runtime image and current artifact/live identity, and preserve independent exit/deadline/cleanup evidence. All browser/dependency-preparation/image/provider/telemetry/public-effect gates remain HOLD. Next named owners/actions: General makes the normal source-integration decision and retains every later separate preparation/run admission. General has been directly asked. Rust #212 is now source-merged at Seven inert source controls and full 484-file verification passed locally; no actual browser or Playwright runtime image was run/pulled. The accepted policy, inventory, candidate and current |
|
Security exact-source disposition — SOURCE/BOUNDED PROPOSAL PASS; BROWSER/PREPARATION/PROVIDER HOLD I independently reviewed exact head The reviewed source correctly bounds the proposed local check:
This is therefore a source/proposal PASS for normal integration. It does not admit dependency preparation, image pull, container creation, a browser attempt, telemetry/provider access, public-rule mutation or rollout. Any later exact-run admission must additionally bind and verify these prerequisites before the first executable byte:
No browser, Playwright runtime, image pull, provider request, telemetry request or public effect was performed in this review. |
|
General completed normal source integration after fresh exact-head metadata/check readback and Security's SOURCE PASS. Qualification was terminal: 11 successes; GitHub reported CLEAN. Actual main is Docs owns ordinary actual-main/Pages/artifact/live acceptance and safe branch cleanup. Preserve the historical packet input until sdk-rust's #212 actual-main/artifact/live handoff is reconciled; then author a narrow reviewed input-retarget successor with Security's external code-sealing and credential-isolated preparation prerequisites. No dependency preparation, image pull, browser, telemetry, provider or public-rule operation is admitted. Central #268 remains open. |
|
#477 source and ordinary Pages delivery are complete at normal merge All six original main workflows and 12 checks pass on attempt 1. Sole automatic protected Pages run 41955257172 and deployment Thirteen actual HTTPS responses match the artifact byte for byte: landing page, all eight localized database-support pages, the complete stable manifest and all three installers. Manifest and installer bytes also match prior and accepted main. The source delta remains the ten reviewed packet/test files; no additional product source changed. The historical input, disabled candidate and current The actual Rust #212 owner handoff is reconciled with my independent full artifact/eight-live-file readback. Per General's assignment, I have started a separate narrow input-retarget branch from this accepted main. It will preserve the executable/browser/runtime bytes while binding the new artifact and documenting the external pre-Node source hash/sealing and credential-isolated preparation prerequisites for fresh review. No preparation, image pull, browser attempt, provider or production telemetry action is admitted or performed. Central #268 remains open. |



The existing local CSP harness skips analytics through its webdriver/loopback path. This prepares the separately reviewable bounded browser/telemetry source packet requested after #476, retaining compatibility controls while exercising the real analytics loader under a local public-origin response map. No browser is run by this PR or normal CI.
The harness verifies every artifact file, fulfills only verified buffers or finite fixtures, blocks service workers/WebSockets, rejects unknown or credential-bearing requests and records request audits. Current published HTML contains no promotion controls, so real-page absence is tested separately from clearly labelled synthetic promotion DOM. Beacon/RUM fixtures test loader/CSP paths and do not establish vendor compatibility or production delivery.
The packet pins the accepted artifact, executable/data hashes, official amd64 image and npm lock. It proposes one network-disabled container with 2 CPUs / 2 GiB / 256 PIDs, a 300-second external deadline and exact-ID cleanup. The candidate, policy, inventory and current
not-runresult remain byte-identical to accepted main. Source integration and any actual preparation/browser attempt require separate reviews/admissions. Rust #212 is an upcoming artifact dependency: any new public artifact requires its actual owner/live handoff and a freshly reviewed input retarget before a run.Validation: Node 24 syntax checks, all seven new inert controls and independent full 484-file input verification pass. The two-package runtime lock audit reports zero advisories. Secret-format, public-boundary and whitespace checks pass; no owned container remains. The actual browser image was neither pulled nor executed, no browser package was imported/executed, and no Cloudflare provider operation or production telemetry request occurred. All eleven exact-head hosted checks now pass, including full eight-locale qualification; normal CI adds only inert source controls to existing qualification. The initial source findings were corrected without suppressions in normal successor 5c376e4. Independent review remains required.
Refs durable-workflow/.github#268. #476 source/Pages delivery is complete at 3548cb9; broader browser/provider/five-host acceptance remains open.