Repository navigation
Tighten the CLI installer checks - #460
Merged
Merged
Conversation
Read the CLI version from static/stable-releases.json instead of pinning it, match the installed version exactly, fail explicitly when the signer substitution is a no-op, and back the generic gh refusal with a control that verifies the same release file with the real signer pin and fails with the substituted one. Run weekly as well as on installer changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sonar S6506: pin curl to https for the request and any redirect, as the other workflows do. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Member
Author
|
General interim review (Security unavailable): CLEAR at b3ce4a8. I reviewed it myself; it's a test-workflow-only follow-up to the independently reviewed #458.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Follow-ups from General's #458 review, all non-blocking. Only
.github/workflows/installers.ymlchanges.static/stable-releases.json(artifacts.cli), not a hard-coded 2.3.5. The CLI 2.5.0 manifest bump will therefore re-run the installers against 2.5.0.static/stable-releases.jsonis added to the PR trigger paths.case "dw $CLI_VERSION ("*and PowerShell uses-match '^dw <escaped version> \('. Previously both did a substring match.! cmp -sis errexit-exempt, so it's replaced with an explicitif cmp -s …; then exit 1. PowerShell compares the replaced text to the original.ghreports only a generic "verifying with issuer" error. So after the refused install, the step verifies the same releaseSHA256SUMStwice: with the real signer pin it must pass, and with the substitutednot-releasepin it must fail. That ties the refusal to the signer identity. I checked both locally against 2.3.5: real → exit 0, substituted → exit 1.workflow_dispatch.Not in this PR:
static/install.shmust be fixed in cli to keep the copy byte-identical.🤖 Generated with Claude Code