[Android] "What’s New" promo message: Add new message type to show a list view #7072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… RMF called What's New. This message type uses a cards_list content structure, allowing for a title, description, and a list of items, each with its own title, description, image, and action.
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
anikiki
changed the title
…ge_add_new_message_type_to_show_a_list_view
cmonfortep
reviewed
Nov 20, 2025
Contributor
cmonfortep
left a comment
cmonfortep
left a comment
There was a problem hiding this comment.
Few comments that I think is best if we review them together.
code looks great, it's just to discuss merging strategy around RMF.
android-design-system/design-system/src/main/java/com/duckduckgo/common/ui/view/MessageCta.kt
Outdated
Show resolved
Hide resolved
android-design-system/design-system/src/main/java/com/duckduckgo/common/ui/view/MessageCta.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/browser/remotemessage/RemoteMessageMapper.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/browser/remotemessage/RemoteMessageMapper.kt
Show resolved
Hide resolved
...aging-impl/src/main/java/com/duckduckgo/remote/messaging/impl/mappers/RemoteMessageMapper.kt
Outdated
Show resolved
Hide resolved
...essaging-impl/src/main/java/com/duckduckgo/remote/messaging/impl/newtab/RemoteMessageView.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/browser/newtab/NewTabLegacyPageView.kt
Outdated
Show resolved
Hide resolved
...ssaging-impl/src/main/java/com/duckduckgo/remote/messaging/impl/mappers/JsonActionMappers.kt
Show resolved
Hide resolved
...g-impl/src/main/java/com/duckduckgo/remote/messaging/impl/mappers/JsonRemoteMessageMapper.kt
Show resolved
Hide resolved
cmonfortep
approved these changes
Nov 26, 2025
Contributor
cmonfortep
left a comment
cmonfortep
left a comment
There was a problem hiding this comment.
LGTM
All test scenarios worked well (tested with production config, attached configs, and mixing them)
anikiki
deleted the
feature/ana/android_whats_new_promo_message_add_new_message_type_to_show_a_list_view
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1211783737656574?focus=true
Description
Added support for a new "What's New" message type in the remote messaging system. This includes:
REMOTE_WHATS_NEW_MESSAGEtype to theMessageCtaclass.CardsListcontent type for displaying feature cards.UrlInContextaction type to open URLs in a contextual webview.Steps to test this PR
See Asana for more details.
NO UI changes