feat: propagate Postgres table and column comments through DuckDB metadata#468
Open
anirudhp-ops wants to merge 1 commit into
Open
feat: propagate Postgres table and column comments through DuckDB metadata#468anirudhp-ops wants to merge 1 commit into
anirudhp-ops wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #450
This PR adds support for Postgres schema comments to show up when
querying DuckDB metadata functions.
Changes
Modified
GetInitializeQueryinpostgres_table_set.cppto joinagainst
pg_descriptionsystem catalog, surfacing both table-leveland column-level comments.
duckdb_tables()duckdb_columns()Testing
Verified manually by setting comments in Postgres and querying
DuckDB metadata:
sql
-- Set comments in Postgres
COMMENT ON TABLE test_comments IS 'this is a test table comment';
COMMENT ON COLUMN test_comments.name IS 'this is a column comment';
-- Verify in DuckDB
SELECT comment FROM duckdb_tables() WHERE table_name = 'test_comments';
-- Returns: 'this is a test table comment'
SELECT column_name, comment FROM duckdb_columns() WHERE table_name = 'test_comments';
-- Returns: name | 'this is a column comment'