Add jemalloc placeholder on Windows #492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the way how `generated_extension_loader_package_build.cpp` is generated in the latest `main` versions of the engine, it expects to have the same set of linked extensions on all platforms. `jemalloc` extension is not available on Windows, so the JDBC build fails on Windows. This PR adds an emtpy placeholder for `JemallocExtension` class that is expected by `generated_extension_loader_package_build.cpp` to fix the compilation on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the way how
generated_extension_loader_package_build.cppis generated in the latestmainversions of the engine, it expects to have the same set of linked extensions on all platforms.jemallocextension is not available on Windows, so the JDBC build fails on Windows.This PR adds an emtpy placeholder for
JemallocExtensionclass that is expected bygenerated_extension_loader_package_build.cppto fix the compilation on Windows.