ci: re-enable 3 excluded test files in CI and Makefile#54
Merged
Conversation
- Fix test_dbt_config_validators.py: migrate parse_obj → model_validate (Pydantic v1 → v2 API) - Fix dbt_config_validators.py: add default=None for Optional fields (test_metadata, project_id, user_id) to match Pydantic v2 semantics - Remove --ignore flags for test_database_types.py, test_main.py, and test_dbt_config_validators.py from ci.yml, ci_full.yml, and Makefile - test_database_types.py and test_main.py self-filter based on available database connections, so they are safe to include in CI Closes #31 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_dbt_config_validators.py: migrateparse_objtomodel_validate(Pydantic v1 to v2)dbt_config_validators.py: adddefault=Nonefor Optional fields (test_metadata,project_id,user_id) to match Pydantic v2 semantics where missing optional fields require explicit defaults--ignoreflags for 3 test files fromci.yml,ci_full.yml, andMakefiletest_database_types.pyandtest_main.pyself-filter based on available DB connectionsKey Files
data_diff/dbt_config_validators.py-- Pydantic v2 Optional field defaultstests/test_dbt_config_validators.py--parse_objtomodel_validate.github/workflows/ci.yml-- remove --ignore flags.github/workflows/ci_full.yml-- remove --ignore flagsMakefile-- remove --ignore flagsTest plan
test_dbt_config_validators.pypasses locally (all 11 subtests)test_database_types.pycollects 182 tests (runs against available DBs)test_main.pycollects 11 tests (runs against available DBs)Closes #31
Generated with Claude Code