Skip to content

fix: MsSQL timezone-safe timestamp normalization via AT TIME ZONE #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dtsong merged 2 commits into from
Mar 30, 2026
Merged

fix: MsSQL timezone-safe timestamp normalization via AT TIME ZONE #51

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d62aed
fix: MsSQL timezone-safe timestamp normalization via AT TIME ZONE
dtsong Mar 30, 2026
71740cb
fix: only apply UTC conversion for TimestampTZ columns in MsSQL
dtsong Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions data_diff/databases/mssql.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,13 @@ def constant_values(self, rows) -> str:
return f"VALUES {values}"

def normalize_timestamp(self, value: str, coltype: TemporalType) -> str:
# For timezone-aware columns (datetimeoffset), convert to UTC explicitly
# since MsSQL cannot set a session timezone.
# For timezone-naive columns (datetime/datetime2), no conversion is possible
# without knowing the source timezone — values are used as-is.
if isinstance(coltype, TimestampTZ):
value = f"{value} AT TIME ZONE 'UTC'"

if coltype.precision > 0:
formatted_value = (
f"FORMAT({value}, 'yyyy-MM-dd HH:mm:ss') + '.' + "
Expand Down
Loading