Repository navigation
Doug/laughing davinci stc796 - #41
Merged
Merged
Conversation
Fixed in code: - tls13_rpk_build_certificate returned nothing on either path (a bare return in a size_t function, and a fall-off at the end). - gen_mlkem_kat: the liboqs cross-check asserted inside a try that caught Exception, so a disagreement was reported as "skipped". - ble_gatt parse: dead return after the switch; h2_conn: unused comma expression; gen_cmake: identical ternary arms; three regexes with ambiguous alternation or a redundant alternative. sonar-project.properties: - The rule suppressions were keyed cpp: while src/ is C and reported under c:, so none applied; they are c: now. - c:S946 (the <Name>V args convention), c:S3519 on quic_server.c (slot pool in the borrow), c:S5332 on http_client.c, and the Python taint, ReDoS, PRNG and namespace-URI rules on tools/ are suppressed with the reason. - tools/ is out of the coverage denominator; the report measures the C. cspell ignores docs/CHANGELOG.md, which is generated from commit subjects.
What is and is not a real finding is the project owner's call. Kept: the existing suppressions moved from cpp: to c: rule keys, so they apply to the C sources as written.
…brary src/ moves onto MMgr, which is a submodule, and no workflow fetched it. Format, docs, interop and the discover/footprint jobs are left without it: none compiles against it, and the format job would otherwise walk MMgr's own sources.
…pins MMgr's CMake fetches embedded_types (b0aacda) at configure time; the Arduino, PlatformIO and ESP-IDF builds have no such step and need it on disk. The CMake build is pointed at the same copy through FETCHCONTENT_SOURCE_DIR_EMBEDDED_TYPES so the two cannot drift.
MMgr's own CMake is not entered. It builds every module once per width environment for its suites, and reaches its include root through CMAKE_SOURCE_DIR, which is this tree's top once MMgr is a subdirectory, so every module failed on mmgr.h. pc_mmgr takes the same three include roots MMgr's mmgr_add_module gives a module and MMgr's default capability switches.
…ry test env The GLOB compiled all five impensa_ancorae_acus profiles, which each define the same table, and two directories MMgr's build does not enter.
… proximus_operor)
…, ssh and udp headers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.