Change CPU arch default value/validation - #4136
Open
un-def wants to merge 1 commit into
Open
Conversation
* In the fleet spec, None/missing value now means "any arch", not "must be inferred and set" * In the run spec, None/missing value now means "any arch supported by the image", not "must be inferred and set" * The arch inferred from the image registry is set per-JobSpec (not RunSpec) via JobConfigurator. As a consequence, resources.cpu.arch must now be set in addition to commands and user to avoid contacting the image registry (e.g., when a local image not pushed to the registry is used) * As the arch is no longer inferred from GPU models, the image/cpu.arch field combination is only validated when cpu.arch is explicitly set to arm. A configuration that requests an NVIDIA ARM chip via gpu but sets neither image nor cpu.arch is valid now * Relaxing resources.cpu.arch from a specific value to null is treated as a compatible change, so re-applying an unchanged configuration after a server upgrade neither redeploys service replicas nor fails the in-place update * image: "scratch" now has a special meaning -- it forces the server to use some dummy defaults instead of contacting the image registry to extract optional field values from the image config. Used by `dstack offer` Fixes: #4056
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dstack offerFixes: #4056