fix(release): stamp plugin.json versions — extra-files glob never worked#351
Merged
Merged
Conversation
release-please extra-files do not support globs, so the "*/.claude-plugin/plugin.json" entry from the unified-versioning change was silently skipped on every release: marketplace.json got stamped to the marketplace version while every plugin.json kept its last manual version. Claude Code keys its plugin cache by plugin.json version and only re-copies content when that version changes, so all content shipped since each plugin's last manual bump (including the v4.2.0 skills migration) never reached installed clients — even after 'claude plugin update', which reports success while re-using the stale same-version cache dir. - Replace the dead glob with one explicit json extra-file per plugin (jsonpath $.version) so future releases stamp every manifest. - One-time stamp of all 17 plugin.json versions to 4.2.0, matching what marketplace.json already claims — forces every installed client to refresh on its next plugin update. Assisted-by: Claude:claude-fable-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Installed clients never received plugin content updates unless someone manually bumped that plugin's
plugin.jsonversion. The v4.2.0 skills migration (#349) — including the three skills that replaced always-loaded agentsmd rules — was invisible to every existing install:claude plugin updatereports success but re-uses the same-version cache directory without re-copying content (verified: cache dir for git-workflows1.8.0dated March, missingpre-commit-architecture, while the refreshed marketplace clone had it).Root cause
release-please
extra-filesdoes not support globs. The"*/.claude-plugin/plugin.json"entry from the unified-versioning change (#142) was silently skipped on every release since:marketplace.jsongot stamped ($.plugins[*].version→ 4.2.0) while everyplugin.jsonkept its last manual version (1.0.0–2.3.1). Claude Code keys its plugin cache byplugin.jsonversion, so same-version content changes never propagate.Fix
jsonpath: $.version, 17 entries) — future releases stamp every manifest, so each release forces cache refreshes.plugin.jsonversions to 4.2.0, matching whatmarketplace.jsonalready claims. After merge, every installed client picks up current content on its nextclaude plugin update.Verification
git diffon the manifests is exactly 17 version lines; all JSON validates.claude plugin marketplace update+claude plugin update <plugin>, cache dirs re-key to 4.2.0 with current content.Refs: dryvist/ai-assistant-instructions#680
🤖 Generated with Claude Code