Publish command catalog, eliminate unknown types, and harden schema#290
Merged
Conversation
Publish the command contract catalog, remove the unreachable unsupported_output_format JSON code, and reject unknown Dropbox metadata types instead of serializing unknown result kinds. Keep help/root JSON behavior documented and covered by tests, and tighten golden contract audits so public schemas and success fixtures stay in sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/json-schema/v1/commands.jsonas the public command contract catalog with a sync test against the internal golden fixtureunsupported_output_formaterror code from code and schemaTestHelpOutputRemainsTextWithJSONFlagverifying help is always text regardless of--output"unknown"metadata type:jsonMetadataFromDropboxnow returns errors instead of silent fallbackscp/mv(performance optimization)"unknown"from all schema kind lists and add contract assertions rejecting itTest plan
TestPublicJSONCommandCatalogMatchesGoldenContractprevents catalog/fixture driftTestHelpOutputRemainsTextWithJSONFlagcovers root help, bare root, and command helpTestJSONMetadataFromDropboxRejectsUnknownMetadataverifies nil metadata errorsassertGoldenCommandStatusesrejects "unknown" in both statuses and kindsassertGoldenSuccessOutputStatusesvalidates all golden output results have explicit status/kindgofmt,go vet,golangci-lintall pass