Add coded errors, JSON warnings, and contract tests#287
Merged
Conversation
Replace fragile string-matching in jsonErrorCode with typed coded errors set at the point of creation. Add warnings infrastructure for deprecated commands and skipped symlinks during recursive upload. Add contract tests that audit the structured output surface and verify the JSON operation output envelope shape.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jsonErrorCodewith typedcodedErrorerrors that carry their error code from the point of creationinvalidArgumentsError(),invalidArgumentsErrorf(),pathConflictErrorf(),unsupportedOutputFormatErrorf()factory helpers used across all commandsrenderJSONOperationOutputWithWarnings()and warning code constants (deprecated_command,skipped_symlink)deprecated_commandwarning when using the legacyshare list linkcommand in JSON modeskipped_symlinkwarning duringput --recursivein JSON mode when symlinks are encounteredTest plan
go test ./cmd/...passes — includes new contract tests and coded error assertionsgolangci-lint run ./...passesTestStructuredOutputCommandAuditfails if a command gains/losesenableStructuredOutputwithout updating the listTestJSONErrorCodeUsesCodedErrorsverifies all coded error types map to correct codesTestJSONErrorCodeDoesNotClassifyPlainValidationStringsensures old string patterns no longer matchTestPutJSONRecursiveWarnsForSkippedSymlinkcreates a real symlink and verifies the warningTestDeprecatedShareListLinkJSONIncludesWarningverifies deprecation warning in output