Preserve case when loading firmware from WSL UNC shares - #142
Open
Prasana-sys wants to merge 1 commit into
Open
Prasana-sys wants to merge 1 commit into
Prasana-sys wants to merge 1 commit into
Conversation
Prasana-sys
force-pushed
the
fix/wsl-unc-firmware-paths
branch
from
September 16, 2026 13:31
62d6dc4 to
677122a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting firmware from a WSL share on Windows can fail with “Specified firmware file is not readable”:
os.path.normcase()changes a directory such asFirmwareProjecttofirmwareproject, which does not exist on the case-sensitive Linux filesystem. The file-server widget repeats the same conversion after selection.Add a shared
normalize_local_path()helper and use it for firmware selection,FileServerWidget.add_path, andPathItem.path. Preserve case for both\\wsl.localhost\and\\wsl$\, including Qt-style forward slashes, while retaining existing normalization for ordinary Windows paths, generic UNC paths, and POSIX paths. The existing short-key firmware protocol stays unchanged.Add 23 pytest cases covering path normalization and the firmware-selection-to-file-read flow, and run them in the existing Python package workflow.
Validation:
FileNotFoundErrorbefore the fix in both namespaces. After the fix, selection, short-key resolution,GetInfo, and 895 chunks totaling 228,892 bytes succeed with matching SHA-256 hashes.The CAN node was simulated; no physical device was flashed. Legacy non-key directory lookup in the DroneCAN dependency is outside this firmware-update fix.