MINOR: Preserve empty list offset buffer#30
Open
prashanthbdremio wants to merge 5 commits into
Open
Conversation
prashanthbdremio
changed the title
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Preserve the Arrow-required empty list offset buffer entry while avoiding malformed Netty buffer state.
ListVectorandLargeListVectornow materialize a one-entry offset buffer when an empty vector still needs to exposeoffset[0], then set the writer index from(valueCount + 1) * OFFSET_WIDTH.This keeps the IPC serialization behavior from apache#967 without producing an ArrowBuf with
writerIndex > capacity, which caused Netty unwrap failures in Dremio sender paths.Testing
mvn -pl vector -am -Dmaven.gitcommitid.skip=true -Dsurefire.failIfNoSpecifiedTests=false -Dtest=TestListVector,TestLargeListVector testResult: BUILD SUCCESS. TestListVector and TestLargeListVector passed under both Netty and Unsafe allocator executions.
Closes DX-122953.