fix(web-security): retry transient Caido/proxy MCP failures instead o…#62
Merged
GangGreenTemperTatum merged 1 commit intoJun 26, 2026
Conversation
…f giving up Three changes to prevent the model from marking proxy MCPs as 'intermittently unavailable' after a single transient failure: 1. mcp/caido.py: safe_get() now retries once (2s delay) before returning an error. CONNECT_TIMEOUT raised from 10s to 30s to accommodate Caido under load or slow token refresh. 2. agents/web-security.md: replaced 'do not retry' proxy guidance with 'retry once -- transient connection issues are common'. Also updated thermoptic guidance for consistency. 3. tests/test_caido_mcp.py: 7 new tests covering retry-on-transient, both-fail-returns-error, client-reset-between-retries, and delay-is-respected. The SDK side (dreadnode-tiger) adds complementary transport-level retry in _make_execute_on_server for the general MCP case. Fixes: CAP-1120
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…f giving up
Three changes to prevent the model from marking proxy MCPs as 'intermittently unavailable' after a single transient failure:
mcp/caido.py: safe_get() now retries once (2s delay) before returning an error. CONNECT_TIMEOUT raised from 10s to 30s to accommodate Caido under load or slow token refresh.
agents/web-security.md: replaced 'do not retry' proxy guidance with 'retry once -- transient connection issues are common'. Also updated thermoptic guidance for consistency.
tests/test_caido_mcp.py: 7 new tests covering retry-on-transient, both-fail-returns-error, client-reset-between-retries, and delay-is-respected.
Fixes: CAP-1120