fix: assist_pattern_key reads username from credential.username for exploit payloads#312
Merged
Merged
Conversation
…ain from payload **Added:** - Introduced new tests to verify assist_pattern_key behavior with nested credential fields, hash_username, and domain fallback, including normalization and preference logic **Changed:** - Updated assist_pattern_key to prioritize extracting username from top-level, then from nested credential, then from hash_username to handle various payload shapes and avoid assist-abandoned dedup bypasses - Enhanced domain extraction logic to fall back to credential.domain when top-level domain is missing, preventing collisions between different authentication realms - Added detailed inline comments explaining the lookup priority and rationale for both username and domain extraction
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/more-attack-cov #312 +/- ##
========================================================
+ Coverage 76.05% 76.06% +0.01%
========================================================
Files 439 439
Lines 118188 118258 +70
========================================================
+ Hits 89884 89954 +70
Misses 28304 28304
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Changes:
Added:
Changed:
Removed: