fix: reject Close packets with unexpected payloads#105
Open
immanuwell wants to merge 1 commit into
Open
Conversation
Signed-off-by: immanuwell <pchpr.00@list.ru>
aea721c to
5887f75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tighten
Closedecoding a bit. Right nowVortex::try_fromacceptsClosepackets with extra bytes, which is kinda wonky becauseCloseis documented and serialized as zero length.Related Issue
Closes #104
Motivation and Context
This is easy to trigger in practice. The malformed packet is only 10 bytes total, so no quota or hard limit gets in the way. Any buggy peer can send it.
Repro on
main:Before this patch it parses as
Vortex::Close(_)and drops the payload on re encode. After this patch it returnsInvalidLength. tiny fix, but it keeps the codec honest.Screenshots (if appropriate)
n/a