Repository navigation
feat(Layout): add IsAutoNavigateWhenNotAuthorize parameter - #8503
Merged
Merged
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdds Layout.IsAutoNavigateWhenNotAuthorize, preserving the existing automatic redirect behavior by default while allowing consumers to disable unauthorized navigation; the location-change handler exits before authorization navigation logic when disabled. Sequence diagram for configurable unauthorized navigationsequenceDiagram
participant Browser
participant Layout
participant Navigation
participant Authorizing
Browser->>Navigation: LocationChanged
Navigation->>Layout: Navigation_LocationChanged
alt IsAutoNavigateWhenNotAuthorize is false
Layout-->>Navigation: return
else IsAutoNavigateWhenNotAuthorize is true
Layout->>Authorizing: OnAuthorizing
Authorizing-->>Layout: authorization result
Layout-->>Navigation: navigate to NotAuthorizeUrl when unauthorized
end
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![bb-auto[bot]](https://avatars.githubusercontent.com/in/287253?s=60&v=4){kind=small}
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="src/BootstrapBlazor/Components/Layout/Layout.razor.cs" line_range="733" />
<code_context>
private void Navigation_LocationChanged(object? sender, LocationChangedEventArgs e)
{
+ // 如果未开启自动跳转未授权地址则不处理
+ if (!IsAutoNavigateWhenNotAuthorize)
+ {
+ return;
</code_context>
<issue_to_address>
**Protected routes render unchecked**
When `IsAutoNavigateWhenNotAuthorize` is false and a route relies on `OnAuthorizing` for authorization, `Navigation_LocationChanged` returns before invoking `OnAuthorizing` or updating `_authenticated`, so callback-based authorization is skipped and the layout can render protected content or keep showing `Main` instead of `NotAuthorized`.
Always run the authorization callback and update the authorization state; use `IsAutoNavigateWhenNotAuthorize` only to gate the redirect.
Also at `src/BootstrapBlazor/Components/Layout/Layout.razor.cs:734-736`.
</issue_to_address>Sourcery assessment
Approval pending. 1 finding to address first.
Blocking findings: src/BootstrapBlazor/Components/Layout/Layout.razor.cs:733
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8503 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 777 777
Lines 35159 35160 +1
=========================================
+ Hits 35159 35160 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sourcery-ai
Bot
dismissed
their stale review
October 9, 2026 06:25
Sourcery withdrew this approval because the latest commits introduced blocking findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #8502
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Allow applications to disable automatic navigation when authorization fails while preserving the existing redirect behavior by default.
New Features:
Tests: