Fix ComboBox dropdown height after clearing or removing all items#14632
Open
JayashreeSF3546 wants to merge 6 commits into
Open
Fix ComboBox dropdown height after clearing or removing all items#14632JayashreeSF3546 wants to merge 6 commits into
JayashreeSF3546 wants to merge 6 commits into
Conversation
…be reset default height after clear the combobox items.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #339
Proposed changes
ComboBoxChildNativeWindowhandling for the dropdown list window.WM_WINDOWPOSCHANGINGfor the native dropdown LISTBOX and updateWINDOWPOS.cywith the managed calculated dropdown height.Items.Count/DropDownHeighteven afterItems.Clear()or removing the last item.Customer Impact
Regression?
Risk
WM_WINDOWPOSCHANGING.IntegralHeightbehavior is preserved while ensuring the final committed dropdown height matches WinForms calculated height.Screenshots
Before
After
Test methodology
WM_WINDOWPOSCHANGINGupdatesWINDOWPOS.cyto the managed calculated dropdown height.Items.Clear().SWP_NOSIZEis set.Accessibility testing
Test environment(s)
Microsoft Reviewers: Open in CodeFlow