Fix PageSetupDialog margin unit conversion mismatch#14494
Open
LeafShi1 wants to merge 2 commits intodotnet:mainfrom
Open
Fix PageSetupDialog margin unit conversion mismatch#14494LeafShi1 wants to merge 2 commits intodotnet:mainfrom
LeafShi1 wants to merge 2 commits intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a unit mismatch in PageSetupDialog by aligning WinForms margin conversions with the unit system used by the native PageSetupDlg dialog, preventing repeated open/OK cycles from drifting margin values on mixed locale configurations.
Changes:
- Switch locale measurement detection to user-default semantics when
EnableMetricis enabled. - Explicitly set the native
PAGESETUPDLGWunit flag (PSD_INHUNDREDTHSOFMILLIMETERSvsPSD_INTHOUSANDTHSOFINCHES) to match the conversion unit used forrtMargin/rtMinMargin.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14482
Root Cause
PageSetupDialog converts pageSettings.Margins and minMargins into rtMargin and rtMinMargin before calling the native dialog.
Previously:
This could lead to mismatched interpretation between values written into rtMargin and values read back in UpdateSettings.
Proposed changes
Customer Impact
Regression?
Risk
Screenshots
Before
After
Note: This requires user verification; we have been unable to reproduce this issue.
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow