-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix dark mode text visibility in Collection Editor dialogs #14129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: SimonZhao888 <133954995+SimonZhao888@users.noreply.github.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #14129 +/- ##
===================================================
+ Coverage 77.15337% 77.15559% +0.00222%
===================================================
Files 3279 3279
Lines 645325 645335 +10
Branches 47720 47721 +1
===================================================
+ Hits 497890 497912 +22
+ Misses 143748 143727 -21
- Partials 3687 3696 +9
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes dark mode text visibility issues in Collection Editor dialogs by changing the selected item text color from SystemColors.HighlightText to SystemColors.ControlText when dark mode is enabled, following the established pattern from CheckedListBox.
Key changes:
- Modified text color selection logic to use
SystemColors.ControlTextin dark mode for better contrast - Applied WFO5001 pragma suppression consistent with other dark mode implementations
...s.Design/src/System/ComponentModel/Design/CollectionEditor.CollectionEditorCollectionForm.cs
Outdated
Show resolved
Hide resolved
...s.Design/src/System/ComponentModel/Design/CollectionEditor.CollectionEditorCollectionForm.cs
Outdated
Show resolved
Hide resolved
...s.Design/src/System/ComponentModel/Design/CollectionEditor.CollectionEditorCollectionForm.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
Proposed changes
CollectionEditor.CollectionEditorCollectionFormto useSystemColors.ControlTextin dark mode instead ofSystemColors.HighlightTextCheckedListBoxdark mode handlingCustomer Impact
#2C62B2on near-black#000C39) to compliant contrastRegression?
No
Risk
Low - single line change following established pattern, affects only dark mode rendering
Screenshots
Before
Text invisible due to poor contrast in dark mode:
After
Text visible with proper contrast (pending manual verification)
Test methodology
CheckedListBox.csimplementationTabControl+PropertyGrid, setApplication.SetColorMode(SystemColorMode.Dark), verify text visibility in Collection EditorAccessibility testing
Manual accessibility testing required post-build to verify WCAG AA contrast compliance.
Test environment(s)
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
rcxvsblobprodcus328.vsblob.vsassets.io/home/REDACTED/work/winforms/winforms/.dotnet/dotnet /home/REDACTED/work/winforms/winforms/.dotnet/dotnet msbuild /m /nologo /clp:Summary /v:minimal /nr:true /warnaserror /p:TreatWarningsAsErrors=true /p:ContinuousIntegrationBuild=false /home/REDACTED/work/winforms/winforms/artifacts/toolset/restore.proj /t:__WriteToolsetLocation /clp:ErrorsOnly;NoSummary /p:__ToolsetLocationOutputFile=/home/REDACTED/work/winforms/winforms/artifacts/toolset/11.0.0-beta.25609.108.txt(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
Microsoft Reviewers: Open in CodeFlow