Draft
Conversation
twsouthwick
force-pushed
the
session-changeset
branch
3 times, most recently
from
c669cbb to
f69ed01
Compare
Previously, the serialization of the session state to go between the remote server and the client would deserialize/serialize every key even if it hadn't changed. As part of this change: - The session state tracks which items are new or have been accessed (and thus potentially changed) - Only sends a diff list rather than all the items - Only deserializes items if they are being accessed - Make the ISessionSerializer internal as its not the preferred way to serialize session state (use
twsouthwick
force-pushed
the
session-changeset
branch
from
f69ed01 to
bbd90dd
Compare
mjrousos
reviewed
Jan 7, 2025
Member
mjrousos
left a comment
mjrousos
left a comment
There was a problem hiding this comment.
Looks good. I left a few questions inline.
...rosoft.AspNetCore.SystemWebAdapters.FrameworkServices/SessionState/SessionStateExtensions.cs
Show resolved
Hide resolved
Member
Author
|
This breaks with the new http2 full duplex mode. will need to rework some things. For now, to not block getting v2.0 of the adapters out, we'll just get #573 in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the serialization of the session state to go between the remote server and the client would
deserialize/serialize every key even if it hadn't changed. As part of this change:
Fixes #503