Skip to content

Fix markdown link checker action reference - #5653

Open
mthalman wants to merge 1 commit into
dotnet:mainfrom
mthalman:mthalman-fix-link-checker-policy
Open

Fix markdown link checker action reference#5653
mthalman wants to merge 1 commit into
dotnet:mainfrom
mthalman:mthalman-fix-link-checker-policy

Conversation

@mthalman

Copy link
Copy Markdown
Member

Problem

The Check Markdown Links workflow fails before creating any jobs because it pins umbrelladocs/action-linkspector to a commit SHA. The dotnet enterprise Actions policy only permits this action through the umbrelladocs/action-linkspector@v1 reference.

Solution

Change the action reference to the enterprise-allowed @v1 tag. Add a comment documenting that the tag is intentional and should not be replaced with a SHA unless the enterprise policy changes.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@mthalman
mthalman requested a review from a team as a code owner August 21, 2026 14:45
@lbussell

Copy link
Copy Markdown
Member

Can we update the policy instead? We should be able to pin it to the sha. /cc @blowdart

@blowdart

Copy link
Copy Markdown

Ah the problem is the allow list of actions?

That should be updated to limit on versions. So either the allow list needs updating to have the sha, or to just allow umbrelladocs/action-linkspector@*.

Obviously being stricter and using the sha in the allow list is safer, however that would mean any time a workflow gets updated with a new version a repo admin will have to update the allow list, which is a huge toil. I'd suggest using the @* approach here as a compromise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants