Repository navigation
Fix VersionConverter for versions without Build/Revision - #136423
Merged
Merged
Conversation
dotnet-policy-service
Bot
added
the
community-contribution
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-componentmodel |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused fix handles each version shape correctly, with regression coverage for every modified conversion path and no unresolved findings.
No open issues 🎉
What changed in this PR
Fixes VersionConverter conversions for versions with unspecified build or revision components, addressing #58331 without changing the public API.
Changes:
- Uses
Version.Clone()to preserve unspecified components when copying versions. - Selects the matching two-, three-, or four-argument constructor for
InstanceDescriptor. - Adds regression tests for version copies and descriptor round trips across all three version shapes.
Builds and tests were not run during this review.
| File | Description |
|---|---|
| src/libraries/System.ComponentModel.TypeConverter/tests/VersionConverterTests.cs | Adds copy and round-trip regression coverage. |
| src/libraries/System.ComponentModel.TypeConverter/src/System/ComponentModel/VersionConverter.cs | Preserves unspecified components in copies and descriptors. |
Review effort: Balanced
jkotas
enabled auto-merge (squash)
October 24, 2026 14:37
Member
|
/ba-g failure is known issue #133328 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #58331