Skip to content

[DO NOT MERGE] #131490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

[DO NOT MERGE] #131490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6431e39
Add DacDbi read-write metadata APIs
Copilot Jul 28, 2026
1899193
Address DacDbi metadata review findings
Copilot Jul 28, 2026
0006b7d
Fix DacDbi metadata validation edge cases
Copilot Jul 28, 2026
04b5ce6
Use DacDbi APIs for writable metadata
Copilot Jul 28, 2026
359d775
Fix writable metadata ownership transfer
Copilot Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/design/datacontracts/EcmaMetadata.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ This contract provides methods to get a view of the ECMA-335 metadata for a give
TargetSpan GetReadOnlyMetadataAddress(ModuleHandle handle);
TargetSpan GetReadWriteSavedMetadataAddress(ModuleHandle handle);
System.Reflection.Metadata.MetadataReader? GetMetadata(ModuleHandle handle);
byte[] GetReadWriteMetadata(ModuleHandle handle);
```

Types from other contracts:
Expand Down Expand Up @@ -172,6 +173,10 @@ MetadataReader? GetMetadata(ModuleHandle handle)
}
```

`GetReadWriteMetadata` reconstructs the module's writable `MDInternalRW` metadata as a contiguous
ECMA-335 metadata image and returns its bytes. It throws `ArgumentException` when the module does
not have writable metadata.

### Helper Methods

``` csharp
Expand Down
1 change: 1 addition & 0 deletions src/coreclr/debug/daccess/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ convert_to_absolute_path(DACCESS_SOURCES ${DACCESS_SOURCES})

add_library_clr(daccess ${DACCESS_SOURCES})
set_target_properties(daccess PROPERTIES DAC_COMPONENT TRUE)
target_compile_definitions(daccess PRIVATE FEATURE_METADATA_INTERNAL_APIS)
target_precompile_headers(daccess PRIVATE [["stdafx.h"]])
target_link_libraries(daccess PRIVATE cdac_api)

Expand Down
Loading
Loading